Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add two-step snap generation process #6

Merged
merged 8 commits into from
Dec 7, 2023

Conversation

vlopes11
Copy link
Contributor

This commit splits the snap generation into two steps. The goal is to allow the user to edit the intermediate generated WASM library to adjust the type resolution to compile his runtime call.

It will still attempt to provide an out-of-the-box correct implementation.

@vlopes11 vlopes11 requested a review from bkolad November 28, 2023 09:20
Copy link
Member

@bkolad bkolad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM do we have to update readme as well?

This commit splits the snap generation into two steps. The goal is to
allow the user to edit the intermediate generated WASM library to adjust
the type resolution to compile his runtime call.

It will still attempt to provide an out-of-the-box correct
implementation.
@vlopes11 vlopes11 force-pushed the vlopes11/feature/generator-steps branch from 6f1932a to f0eb57b Compare December 7, 2023 20:26
@vlopes11 vlopes11 merged commit f283647 into main Dec 7, 2023
1 check passed
@vlopes11 vlopes11 deleted the vlopes11/feature/generator-steps branch December 7, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants