Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Set cluster name in the OCCM #132

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

michal-gubricky
Copy link
Contributor

@michal-gubricky michal-gubricky commented Jul 8, 2024

What this PR does / why we need it:
This PR sets the cluster name in the OCCM to make the name for the ingress-nginx load balancer unique

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes SovereignCloudStack/k8s-cluster-api-provider#495

Tested with the cluster name set to cs-cluster:

k describe po openstack-cloud-controller-manager-9l724 -n kube-system --kubeconfig cs-cluster.kubeconfig
Containers:
  openstack-cloud-controller-manager:    
    Environment:
      CLOUD_CONFIG:  /etc/config/cloud.conf
      CLUSTER_NAME:  cs-cluster

After the installation of Ingress-NGINX, the load balancer was created in the gx-scs with the expected name, see attached pic.
lb

Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
@michal-gubricky michal-gubricky force-pushed the feat/set-cluster-name-occm branch from 577c198 to c297903 Compare July 8, 2024 10:51
@michal-gubricky michal-gubricky marked this pull request as ready for review July 8, 2024 11:21
Copy link
Member

@chess-knight chess-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jschoone jschoone merged commit d4c02cf into main Jul 8, 2024
2 checks passed
@jschoone jschoone deleted the feat/set-cluster-name-occm branch July 8, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefix all resources with PREFIX and CLUSTER_NAME
3 participants