-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Operator Docs Introduction #109
Conversation
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering the two TODO is this ready for review?
Well, except for the both TODOs it's ready for review. |
# Conflicts: # docs/index.md
Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com>
Co-authored-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> Signed-off-by: Max Wolfs <mail@maxwolfs.com>
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
…reignCloudStack/docs into feat/refactor-operator-introduction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I discussed some minor graphical issues with Max directly:
Here are more suggestions for some minor changes in wording.
Other than that, LGTM.
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
Co-authored-by: Filip Dobrovolný <dobrovolny.filip@gmail.com> Signed-off-by: Max Wolfs <mail@maxwolfs.com>
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
f7dd985
to
27e697d
Compare
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
…reignCloudStack/docs into feat/refactor-operator-introduction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, just two minor suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see also #152 - missing k8s-cluster-api-provider docs
Co-authored-by: Roman Hros <roman.hros@dnation.cloud> Signed-off-by: Max Wolfs <mail@maxwolfs.com>
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked only at changes since my last review, looks perfect 👼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* remove deprecated parts Signed-off-by: Max Wolfs <mail@maxwolfs.com> * fix linkg Signed-off-by: Max Wolfs <mail@maxwolfs.com> * feat: add cluster stacks description Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> Signed-off-by: Max Wolfs <mail@maxwolfs.com> * refactor components for better reuse with json Signed-off-by: Max Wolfs <mail@maxwolfs.com> * import architecture component Signed-off-by: Max Wolfs <mail@maxwolfs.com> * fix loading Signed-off-by: Max Wolfs <mail@maxwolfs.com> * Apply suggestions from code review Co-authored-by: Filip Dobrovolný <dobrovolny.filip@gmail.com> Signed-off-by: Max Wolfs <mail@maxwolfs.com> * add first single components to overview component Signed-off-by: Max Wolfs <mail@maxwolfs.com> * Adjust model Signed-off-by: Max Wolfs <mail@maxwolfs.com> * add custom data plugin Signed-off-by: Max Wolfs <mail@maxwolfs.com> * fix url Signed-off-by: Max Wolfs <mail@maxwolfs.com> * fix url Signed-off-by: Max Wolfs <mail@maxwolfs.com> * fix: typo Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> * fix calendar link Signed-off-by: Max Wolfs <mail@maxwolfs.com> * Add container registry docs and display it on the overview map (SovereignCloudStack#143) Signed-off-by: Matej Feder <matej.feder@dnation.cloud> * Add monitoring docs and display it on the overview map (SovereignCloudStack#144) Signed-off-by: Matej Feder <matej.feder@dnation.cloud> * Add CSPO docs and display it on the overview map (SovereignCloudStack#149) Signed-off-by: Matej Feder <matej.feder@dnation.cloud> * fix component sizing Signed-off-by: Max Wolfs <mail@maxwolfs.com> * Apply suggestions from code review Co-authored-by: Roman Hros <roman.hros@dnation.cloud> Signed-off-by: Max Wolfs <mail@maxwolfs.com> * Add missing k8s-cluster-api-provider doc pages (SovereignCloudStack#152) Signed-off-by: Roman Hros <roman.hros@dnation.cloud> * fix title Co-authored-by: Roman Hros <roman.hros@dnation.cloud> Signed-off-by: Max Wolfs <mail@maxwolfs.com> --------- Signed-off-by: Max Wolfs <mail@maxwolfs.com> Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> Signed-off-by: Matej Feder <matej.feder@dnation.cloud> Signed-off-by: Roman Hros <roman.hros@dnation.cloud> Co-authored-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> Co-authored-by: Filip Dobrovolný <dobrovolny.filip@gmail.com> Co-authored-by: Matej Feder <matej.feder@dnation.cloud> Co-authored-by: Roman Hros <roman.hros@dnation.cloud>
closes #103
closes #64
closes #136