Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Operator Docs Introduction #109

Merged
merged 41 commits into from
Mar 4, 2024
Merged

Conversation

maxwolfs
Copy link
Member

@maxwolfs maxwolfs commented Nov 8, 2023

closes #103
closes #64
closes #136

Signed-off-by: Max Wolfs <mail@maxwolfs.com>
Copy link
Contributor

@fdobrovolny fdobrovolny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering the two TODO is this ready for review?

@maxwolfs
Copy link
Member Author

Considering the two TODO is this ready for review?

Well, except for the both TODOs it's ready for review.

maxwolfs and others added 5 commits January 10, 2024 13:17
Co-authored-by: Jan Schoone <6106846+jschoone@users.noreply.github.com>
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
…reignCloudStack/docs into feat/refactor-operator-introduction
@maxwolfs maxwolfs requested a review from fdobrovolny January 12, 2024 14:31
Copy link
Contributor

@fdobrovolny fdobrovolny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I discussed some minor graphical issues with Max directly:

Here are more suggestions for some minor changes in wording.

Other than that, LGTM.

maxwolfs and others added 3 commits January 12, 2024 16:40
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
Co-authored-by: Filip Dobrovolný <dobrovolny.filip@gmail.com>
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
@maxwolfs maxwolfs force-pushed the feat/refactor-operator-introduction branch from f7dd985 to 27e697d Compare January 17, 2024 13:34
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
@jschoone jschoone self-requested a review February 5, 2024 16:00
Copy link
Member

@chess-knight chess-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just two minor suggestions

Copy link
Member

@chess-knight chess-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see also #152 - missing k8s-cluster-api-provider docs

maxwolfs and others added 2 commits March 1, 2024 11:39
Co-authored-by: Roman Hros <roman.hros@dnation.cloud>
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Copy link
Contributor

@fdobrovolny fdobrovolny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked only at changes since my last review, looks perfect 👼

Co-authored-by: Roman Hros <roman.hros@dnation.cloud>
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
Copy link
Member

@matofeder matofeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maxwolfs maxwolfs merged commit 90cc7a0 into main Mar 4, 2024
4 checks passed
@maxwolfs maxwolfs deleted the feat/refactor-operator-introduction branch March 4, 2024 08:30
JuanPTM pushed a commit to JuanPTM/docs that referenced this pull request Jun 3, 2024
* remove deprecated parts

Signed-off-by: Max Wolfs <mail@maxwolfs.com>

* fix linkg

Signed-off-by: Max Wolfs <mail@maxwolfs.com>

* feat: add cluster stacks description

Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Jan Schoone <6106846+jschoone@users.noreply.github.com>
Signed-off-by: Max Wolfs <mail@maxwolfs.com>

* refactor components for better reuse with json

Signed-off-by: Max Wolfs <mail@maxwolfs.com>

* import architecture component

Signed-off-by: Max Wolfs <mail@maxwolfs.com>

* fix loading

Signed-off-by: Max Wolfs <mail@maxwolfs.com>

* Apply suggestions from code review

Co-authored-by: Filip Dobrovolný <dobrovolny.filip@gmail.com>
Signed-off-by: Max Wolfs <mail@maxwolfs.com>

* add first single components to overview component

Signed-off-by: Max Wolfs <mail@maxwolfs.com>

* Adjust model

Signed-off-by: Max Wolfs <mail@maxwolfs.com>

* add custom data plugin

Signed-off-by: Max Wolfs <mail@maxwolfs.com>

* fix url

Signed-off-by: Max Wolfs <mail@maxwolfs.com>

* fix url

Signed-off-by: Max Wolfs <mail@maxwolfs.com>

* fix: typo

Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com>

* fix calendar link

Signed-off-by: Max Wolfs <mail@maxwolfs.com>

* Add container registry docs and display it on the overview map (SovereignCloudStack#143)

Signed-off-by: Matej Feder <matej.feder@dnation.cloud>

* Add monitoring docs and display it on the overview map (SovereignCloudStack#144)

Signed-off-by: Matej Feder <matej.feder@dnation.cloud>

* Add CSPO docs and display it on the overview map (SovereignCloudStack#149)

Signed-off-by: Matej Feder <matej.feder@dnation.cloud>

* fix component sizing

Signed-off-by: Max Wolfs <mail@maxwolfs.com>

* Apply suggestions from code review

Co-authored-by: Roman Hros <roman.hros@dnation.cloud>
Signed-off-by: Max Wolfs <mail@maxwolfs.com>

* Add missing k8s-cluster-api-provider doc pages (SovereignCloudStack#152)

Signed-off-by: Roman Hros <roman.hros@dnation.cloud>

* fix title

Co-authored-by: Roman Hros <roman.hros@dnation.cloud>
Signed-off-by: Max Wolfs <mail@maxwolfs.com>

---------

Signed-off-by: Max Wolfs <mail@maxwolfs.com>
Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com>
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Co-authored-by: Jan Schoone <6106846+jschoone@users.noreply.github.com>
Co-authored-by: Filip Dobrovolný <dobrovolny.filip@gmail.com>
Co-authored-by: Matej Feder <matej.feder@dnation.cloud>
Co-authored-by: Roman Hros <roman.hros@dnation.cloud>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants