Skip to content

Conversation

@mbuechse
Copy link
Contributor

Closes #933

@mbuechse mbuechse requested review from fkr and garloff September 16, 2025 12:09
@mbuechse mbuechse marked this pull request as draft September 16, 2025 12:09
@chrisschwa
Copy link
Contributor

Should the image_source format always be from the osism repository or should we not be able to host our own images?

@mbuechse
Copy link
Contributor Author

Should the image_source format always be from the osism repository or should we not be able to host our own images?

This is up for debate. So far, this hasn't come up. If other people want to host the image, they can probably be added, given that the relevant bodies agree.

Copy link
Member

@garloff garloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another comment:
We've had standardized image names before. Shouldn't we keep them as a recommendation? This would reduce the chance for breakage of customer automation ...


### Official SCS CAPI images

| status | name scheme |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we specify os_distro and os_purpose in this table as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. I think these images are to be found via name, because os_distro and os_purpose are not specific enough, or are they?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But they still should be set correctly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, but this should be mandated by scs-0101 already. The same is true for the plain OS images, though. I will work on it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, the thing is this:

  • in the first table, we say "an image with this combination of properties MUST/SHOULD exist"
  • in the second table, we say "an image with this name SHOULD exist"
  • scs-0101-v2 mandates the correct use of os_purpose and os_distro; we don't do that here

Therefore, IMO we shouldn't specify the property values here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garloff Is this solved for you?

Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
@mbuechse mbuechse marked this pull request as ready for review December 1, 2025 20:14

the value of the property `image_source` MUST have the form

https://swift.services.a.regiocloud.tech/swift/v1/AUTH_b182637428444b9aa302bb8d5a5a418c/openstack-k8s-capi-images/...
Copy link
Member

@garloff garloff Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
https://swift.services.a.regiocloud.tech/swift/v1/AUTH_b182637428444b9aa302bb8d5a5a418c/openstack-k8s-capi-images/...
https://nbg1.your-objectstorage.com/osism/openstack-k8s-capi-images/...

See https://github.com/osism/k8s-capi-images (which should be in image_description).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also mention that the os_purpose for these MUST be set to k8snode and that image_description be set to https://github.com/osism/k8s-capi-images.
Provider are free to register capi images with a different naming scheme from different source.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that. It's more fitting here than in the section below. I will implement this.

Shall we allow the old URL to remain backwards compatible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the text accordingly --- with the old URL for backwards compatibility. @garloff please have another look.


### Generic OS images

For an OS image with `os_purpose=generic`, the `image_source` SHOULD come from the original vendor.
Copy link
Member

@garloff garloff Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For an OS image with `os_purpose=generic`, the `image_source` SHOULD come from the original vendor.
For an OS image with `os_purpose=generic`, the `image_source` SHOULD come from the original vendor. This allows the user to download and inspect the image - the registered image thus MUST NOT be changed from the one that can be downloaded from the `image_source` URL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, but I'm pretty positive it belongs into scs-0102 (image metadata).

Co-authored-by: Kurt Garloff <kurt@garloff.de>
Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend standard images standard to move away from fixed names

6 participants