Skip to content

Commit

Permalink
#66 Add PHP 8.0 compatibility (#67)
Browse files Browse the repository at this point in the history
* Upgrade symfony/yaml to fix issue with abs() call

- also upgraded all modules that did not support php 8.0
- one of the modules upgraded was phpunit which modified the declaration of the setUp function so I will need to go through all our tests and modify the function declaration to match the parent.

* DEV-91 Update tests to match declaration of setUp() and tearDown()

* DEV-91 Fix test errors and failures

* DEV-91 Fix test warnings and issue with schema

* DEV-91 fix obscure symfony warning

* DEV-91 fix phpcs warnings

- also ignore if statement assignment rule

* DEV-91 fix phpcs warnings

- also ignore if statement assignment rule
- lock symfony/deprecation-contracts to version that supports php versions bellow 8

* Modify tests to only run php > 7.4

* Update Php version constraints

* Update changelog

* Use the right date in changelog

* Update manifest.json

Co-authored-by: vladcostin <vlad@space48.com>
  • Loading branch information
vlad1992 and vladcostin authored Mar 9, 2022
1 parent 8831188 commit b03b94c
Show file tree
Hide file tree
Showing 31 changed files with 1,767 additions and 784 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/php.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ jobs:
strategy:
matrix:
operating-system: [ubuntu-latest]
php-version: ['7.0', '7.1', '7.2', '7.3', '7.4']
php-version: ['7.4', '8.0']
runs-on: ${{ matrix.operating-system }}
steps:
- name: Checkout
Expand Down
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,14 @@ All notable changes will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [4.0.0] - 2022-03-08

### Fixed
Issues with PHP 8 compatibility

### Removed
Compatibility with PHP < 7.4

## [3.0.1] - 2020-12-11

### Fixed
Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ It was written with developers in mind and provides commands for:

## Requirements

* PHP 7.0+ (with permission to run `exec` and `passthru`)
* `<v4.0.0` PHP >7.0 <8.0(with permission to run `exec` and `passthru`)
* `>v4.0.0` PHP 7.4+
* `mysql` client on the `$PATH`

## Installation
Expand Down
13 changes: 7 additions & 6 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,23 +25,24 @@
"bin/magedbm2"
],
"require": {
"php": "~7.0",
"php": ">=7.4",
"symfony/console": "^3.4",
"symfony/yaml": "^3.4",
"aws/aws-sdk-php": "^3.52",
"meanbee/libmageconf": "^1.0",
"symfony/process": "^3.4",
"psr/log": "^1.0",
"fzaninotto/faker": "^1.7",
"php-di/php-di": "^6.0",
"adbario/php-dot-notation": "^2.0"
"adbario/php-dot-notation": "^2.0",
"fakerphp/faker": "^1.9",
"symfony/deprecation-contracts": "2.5"
},
"require-dev": {
"phpunit/phpunit": "^6.1.4",
"phpunit/phpunit": "^9.5",
"squizlabs/php_codesniffer": "^3.0.0",
"phpmd/phpmd": "^2.6.0",
"phpmd/phpmd": "^2.11",
"php-vfs/php-vfs": "^1.4",
"wimg/php-compatibility": "^8.1"
"phpcompatibility/php-compatibility": "^9.3"
},
"autoload": {
"psr-4": {
Expand Down
Loading

0 comments on commit b03b94c

Please sign in to comment.