Integrate new shop apis + bug fixes #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @sonylomo, this PR is still a WIP. |
alvyynm
changed the title
JimmyTron
approved these changes
Sep 9, 2024
CodedVeli
added a commit
that referenced
this pull request
Sep 16, 2024
Co-authored-by: sonylomo <sonylomo1@gmail.com> [Have you read the contributing guidelines ?](https://github.com/SpaceyaTech/SYT-Web-Redesign/blob/Dev/docs/CONTRIBUTING.md) # What is the purpose of your _pull request_? - [ ] Bug fix - [ ] New feature - [ ] Documentation # Proposed changes # Warning Please read these points carefully and answer honestly with an `X` into all the boxes. Example : [X] Before submitting a _pull request_ make sure you have: - [ ] Read the guidelines for contributing. - [ ] Wrote some tests. - [ ] Respected the linting guidelines (read the guide below for help). ## How to Check and Fix Linting Issues Run `npm run validate`. This command will run prettier and eslint checks to ensure linting guidelines are respected. - If the command exits with code 0 (build is successful), there are no linting issues. - If the command exits with a code other than 0, scroll up the command output and look for identified linting issues. Fix them and revalidate to check if the issues have been resolved by re-running the command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you read the contributing guidelines ?
What is the purpose of your pull request?
Proposed changes
Resolves #228 by integrating the new shop api to the product detail page.
In addition to that, the PR introduces the following changes:
sluginstead ofid./shopand/shop/item/:sluguseDeleteAllSwagmutation hook to clear backend cart items once the user makes an order(From the video below, I've noted some UI issues. I'll fix soon #230. If you notice more, let me know, and I'll add them to #230)
Recording.9.mp4
Existing issues I encountered while working with the API
/checkoutAPI endpoint for placing an order currently expectscityto be anint(This should be astr, not anint). The API response is as follows: "Incorrect type. Expected pk value, received str."GET/api/cart-items/clear_cart/returns 404 status codeWarning
Please read these points carefully and answer honestly with an
Xinto all the boxes. Example : [X]
Before submitting a pull request make sure you have: