Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trims off effect layers, makes rendering a bit more sane #295

Merged
merged 5 commits into from
Jul 5, 2024
Merged

Trims off effect layers, makes rendering a bit more sane #295

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8cbce5d
Adds a wider span for layers without mixup with planes
LemonInTheDark Jul 5, 2024
239a078
let's lower that down to make INF less likely
LemonInTheDark Jul 5, 2024
ba75909
fuckoff big number
LemonInTheDark Jul 5, 2024
f1531ea
offset strategy
LemonInTheDark Jul 5, 2024
fba1539
Merge branch 'main' of https://github.com/SpaiR/StrongDMM into but-se…
LemonInTheDark Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions internal/app/render/bucket/level/chunk/unit/unit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,21 @@
plane, _ := p.Vars().Float("plane")
layer, _ := p.Vars().Float("layer")

// Layers can have essentially effect values added onto them
// We should clip them off to reduce the max possible layer to like 4999 (likely far lower)
const BACKGROUND_LAYER = 20_000
const TOPDOWN_LAYER = 10_000
const EFFECTS_LAYER = 5000
if layer > BACKGROUND_LAYER {
layer -= BACKGROUND_LAYER
}
if layer > TOPDOWN_LAYER {
layer -= TOPDOWN_LAYER
}
if layer > EFFECTS_LAYER {
layer -= EFFECTS_LAYER
}

Check failure on line 108 in internal/app/render/bucket/level/chunk/unit/unit.go

View workflow job for this annotation

GitHub Actions / Lint Source Code 

File is not `gofmt`-ed with `-s` (gofmt)
layer = plane*10_000 + layer*1000

// When mobs are on the same Layer with object they are always rendered above them (BYOND specific stuff).
Expand Down
Loading