Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set all needed glPixelStore states #298

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Set all needed glPixelStore states #298

merged 2 commits into from
Nov 12, 2024

Conversation

RaphiMC
Copy link
Contributor

@RaphiMC RaphiMC commented Nov 9, 2024

Fixes a crash when trying to upload the texture if the application (Tested with Minecraft 1.21.3) changed one of the 3 added states before ImGui was initialized

Type of change

  • Minor changes or tweaks (quality of life stuff)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Fixes a crash when trying to upload the texture if the application changed one of the 3 added states before ImGui was initialized
@SpaiR SpaiR added the chore Routine tasks, refactoring, updates, minor improvements label Nov 10, 2024
@SpaiR
Copy link
Owner

SpaiR commented Nov 10, 2024

@RaphiMC as you can see, the code currently doesn't compile

@RaphiMC
Copy link
Contributor Author

RaphiMC commented Nov 10, 2024

@RaphiMC as you can see, the code currently doesn't compile

Fixed the imports

@SpaiR SpaiR merged commit 4b0cf7b into SpaiR:main Nov 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Routine tasks, refactoring, updates, minor improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants