Skip to content

Commit

Permalink
Make old scan obsolete
Browse files Browse the repository at this point in the history
  • Loading branch information
kirillgarbar committed Apr 7, 2024
1 parent d82b6ac commit 049b4b3
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 6 deletions.
2 changes: 2 additions & 0 deletions src/GraphBLAS-sharp.Backend/Common/PrefixSum.fs
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,8 @@ module internal PrefixSumInternal =
/// </example>
/// <param name="clContext">ClContext.</param>
/// <param name="workGroupSize">Should be a power of 2 and greater than 1.</param>
[<System.ObsoleteAttribute("This method is deprecated due to bad perfomance. Use method from Scan module instead.",
false)>]
let standardExcludeInPlace (clContext: ClContext) workGroupSize =

let scan =
Expand Down
4 changes: 2 additions & 2 deletions src/GraphBLAS-sharp.Backend/Common/Sort/Radix.fs
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ module internal Radix =
let count = count clContext workGroupSize mask

let prefixSum =
PrefixSumInternal.standardExcludeInPlace clContext workGroupSize
ScanInternal.standardExcludeInPlace clContext workGroupSize

let scatter = scatter clContext workGroupSize mask

Expand Down Expand Up @@ -259,7 +259,7 @@ module internal Radix =
let count = count clContext workGroupSize mask

let prefixSum =
PrefixSumInternal.standardExcludeInPlace clContext workGroupSize
ScanInternal.standardExcludeInPlace clContext workGroupSize

let scatterByKey =
scatterByKey clContext workGroupSize mask
Expand Down
6 changes: 3 additions & 3 deletions src/GraphBLAS-sharp.Backend/Common/Sum.fs
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ module Reduce =
Scatter.lastOccurrence clContext workGroupSize

let prefixSum =
PrefixSumInternal.standardExcludeInPlace clContext workGroupSize
ScanInternal.standardExcludeInPlace clContext workGroupSize

fun (processor: MailboxProcessor<_>) allocationMode (keys: ClArray<int>) (values: ClArray<'a option>) ->

Expand Down Expand Up @@ -661,7 +661,7 @@ module Reduce =
Scatter.lastOccurrence clContext workGroupSize

let prefixSum =
PrefixSumInternal.standardExcludeInPlace clContext workGroupSize
ScanInternal.standardExcludeInPlace clContext workGroupSize

fun (processor: MailboxProcessor<_>) allocationMode (resultLength: int) (offsets: ClArray<int>) (keys: ClArray<int>) (values: ClArray<'a>) ->

Expand Down Expand Up @@ -940,7 +940,7 @@ module Reduce =
Scatter.lastOccurrence clContext workGroupSize

let prefixSum =
PrefixSumInternal.standardExcludeInPlace clContext workGroupSize
ScanInternal.standardExcludeInPlace clContext workGroupSize

fun (processor: MailboxProcessor<_>) allocationMode (resultLength: int) (offsets: ClArray<int>) (firstKeys: ClArray<int>) (secondKeys: ClArray<int>) (values: ClArray<'a>) ->

Expand Down
2 changes: 1 addition & 1 deletion src/GraphBLAS-sharp.Backend/Operations/SpMSpV.fs
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ module SpMSpV =
inputArray.[i] <- 0 @>

let sum =
PrefixSumInternal.standardExcludeInPlace clContext workGroupSize
ScanInternal.standardExcludeInPlace clContext workGroupSize

let prepareOffsets = clContext.Compile prepareOffsets

Expand Down

0 comments on commit 049b4b3

Please sign in to comment.