Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build against 2023.3-EAP7-SNAPSHOT #205

Merged
merged 5 commits into from
Nov 18, 2023
Merged

Build against 2023.3-EAP7-SNAPSHOT #205

merged 5 commits into from
Nov 18, 2023

Conversation

ajeckmans
Copy link
Contributor

@ajeckmans ajeckmans commented Nov 17, 2023

Build against 2023.3-EAP7-SNAPSHOT and properly set the target version to the 2023.* range of versions (any less restrictive does not work).

…the 2023.* range of versions (any less restrictive does not work).
@ajeckmans ajeckmans changed the title Build against 2023.3-SNAPSHOT Build against 2023.3-EAP7-SNAPSHOT Nov 17, 2023
@Socolin
Copy link
Collaborator

Socolin commented Nov 17, 2023

Look good, can you just add the Changelog too ?

@ajeckmans
Copy link
Contributor Author

@Socolin there was still an issue. Let me fix that first

@ajeckmans
Copy link
Contributor Author

There :)

@Socolin Socolin merged commit 87b1053 into SpecFlowOSS:master Nov 18, 2023
1 check passed
@ajeckmans ajeckmans deleted the build-against-2023.3-SNAPSHOT branch November 18, 2023 17:20
@Socolin
Copy link
Collaborator

Socolin commented Nov 20, 2023

Were you able to run the build ? I'm getting errors when testing it.

To test you should be able to run ./gradlew :runIde (or the .bat on windows)

You miss the update in Plugin.props, I'll fix this

@ajeckmans
Copy link
Contributor Author

I was running it using the rider launch thingie and there it was loading the plugin.
I'll run that command next time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants