Remove unnecessary dependence on micros() for neopixel libs #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the cases where we don;t have micros(), we now issue warning, and we now correctly include rtc millis cases, where they were previously not checked for.
|
Issue raised in #158 - this change is in both branches. |
|
Tried the update now. |
SpenceKonde
added a commit
that referenced
this pull request
Feb 24, 2021
Static had an extra close paren, whilethe non-static one was missing a close paren for a defined()..... #333
|
Yup. Static had an extra close paren, non-static missing one, and I didn't bother to check the CI results. Terribad! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the cases where we don;t have micros(), we now issue warning, and we now correctly include rtc millis cases, where they were previously not checked for.