forked from huggingface/lerobot
-
Notifications
You must be signed in to change notification settings - Fork 0
HIL-SERL tutorial for simulation fixed and expanded #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
spirosperos
wants to merge
35
commits into
SpesRobotics:main
from
spirosperos:feature-hil-serl-sim-tutorial
Closed
HIL-SERL tutorial for simulation fixed and expanded #1
spirosperos
wants to merge
35
commits into
SpesRobotics:main
from
spirosperos:feature-hil-serl-sim-tutorial
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngface#1609) * fix(policies): remove action from batch for offline evaluation in diffusion, tdmpc, and vqbet policies * style(diffusion): correct comment capitalization for clarity in modeling_diffusion.py
* fix bug about sampling t from beta distribution * fix: address review comments ---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Michel Aractingi <michel.aractingi@huggingface.co>
…ngface_hub dependencies (huggingface#1618)
…ould crash with exception, fix environment state docs (huggingface#1617) * Fix bug in diffusion config validation when not using image features * Fix DiffusionPolicy docstring about shape of env state
…both OpenCV and RealSense camera implementations
Co-authored-by: Michel Aractingi <michel.aractingi@huggingface.co>
Signed-off-by: Francesco Capuano <74058581+fracapuano@users.noreply.github.com>
…face#1643) * chore(ci): add some release stuff * chore(ci): add requirements-macos * chore(ci): added lockfiles for future reference * feat(ci): add draft & prerelease option to release workflow tag
* Cleanup badges * Remove comment * Remove profiling section * Move acknowledgment * Move citations * Fix badge display * Move build your robot section * Fix nightly badge * Revert be13b3f * Update README.md Co-authored-by: HUANG TZU-CHUN <tzu.chun.huang.tw@gmail.com> Signed-off-by: Simon Alibert <75076266+aliberts@users.noreply.github.com> * chore(docs): optimize readme for PyPI rendering * chore(docs): move policy readme to docs folder + symlink in policy dirs * fix(docs): max width og lerobot logo + url in citation block --------- Signed-off-by: Simon Alibert <75076266+aliberts@users.noreply.github.com> Co-authored-by: HUANG TZU-CHUN <tzu.chun.huang.tw@gmail.com> Co-authored-by: Steven Palma <steven.palma@huggingface.co>
* add: test to check proper construction with multiple features with STATE/ACTION type * fix: robot and action state should match policy's expectations * fix minor Signed-off-by: Francesco Capuano <74058581+fracapuano@users.noreply.github.com> --------- Signed-off-by: Francesco Capuano <74058581+fracapuano@users.noreply.github.com>
…te URLs (huggingface#1313) * Update links to use absolute URLs. * Update dataset upload example link to use HF_USER variable and match the correct syntax.
Member
|
There is a mess up with the branches, fixed in #2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
This PR fixes two critical bugs in the HIL-SERL simulation training framework and adds comprehensive documentation:
Bug Fixes:
control_time_sparameter not being respected during training - episodes were always 10 seconds regardless of configurationrandom_block_positionflag not being properly passed to the gym environment, preventing cube randomizationImprovements:
hil_serl_simulation_training_guide_README.md) for HIL-SERL simulation trainingKey Changes:
TimeLimitWrapperclass to properly enforce episode time limits based oncontrol_time_sconfigurationrandom_block_positionparameter to environment configuration and properly passed it to gym environmentHow it was tested
"control_time_s": 40.0in configuration now properly limits episodes to 40 seconds instead of default 10 seconds"random_block_position": truenow properly randomizes cube positions between episodesTest Commands:
How to checkout & try? (for the reviewer)
# Modify control_time_s in hi_rl_test_gamepad.json to 20.0 and verify episodes last 20 seconds python -m lerobot.scripts.rl.gym_manipulator --config_path examples/hil_serl_simulation_training/hi_rl_test_gamepad.json# Check the new training guide cat examples/hil_serl_simulation_training/hil_serl_simulation_training_guide_README.mdExpected Behavior:
control_time_ssetting (30s in training config, 40s in recording config)random_block_position: true