This repository has been archived by the owner on May 14, 2020. It is now read-only.
Revert #578 #1616
Open
Revert #578 #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this fell through the cracks. Might be a good time to revisit. |
|
Today's meeting outcome: Update commit message to explain why we reverting these changes (including why we double decode) before merging. |
fgsch
force-pushed
the
fgsch/revert-pr-578
branch
2 times, most recently
from
48a46c6
to
8e9e444
Compare
|
Is there anything left to do here? (Still carries tag...) |
|
Right. I still need to update the commit message, which I hope to do this week. |
fgsch
force-pushed
the
fgsch/revert-pr-578
branch
from
8e9e444
to
19016d9
Compare
|
This PR is on the agenda for tonight. If it could be fixed up during the day, we can merge immediately and save time. |
Stop decoding things twice. See SpiderLabs#590 for details.
fgsch
force-pushed
the
fgsch/revert-pr-578
branch
from
19016d9
to
c67ed8b
Compare
|
Thank you. All tests are passing now. Ready to be merged? |
|
Update: waiting for the commit message update explaining why. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop decoding things twice. See #590 for details.