Remove req msg dot

[nerrehmit]

This fixes #1622 by removing all the trailing dots in the msg action.

It can be verified by comparing the google docs with the messages before the change and after
Thanks to @airween for patiently explaining msc_pyparser to me and writing a python script to find all the msg dot actions in the referenced issue.

[nerrehmit]

I don't know if we would want to prevent msg actions with a trailing dot in the future by some kind of automated tests? I have no idea if this is possible and if so how to go about it.

[airween]

LGTM - thanks @nerrehmit.

[airween]

I don't know if we would want to prevent msg actions with a trailing dot in the future by some kind of automated tests? I have no idea if this is possible and if so how to go about it.

I started to work on a CRS testing utility, but I think the concept (in this form) is not well. We need to re-think this process, and may be first time only to propose for the developers in documentation. Otherwise, there are so many idea what we can check automatically - see the example/ dir of msc_pyparser.

[fgsch]

Looks good.

One small nitpick: can you also update the commented out rule in REQUEST-910-IP-REPUTATION.conf?

# msg:'Client IP in Trustwave SpiderLabs IP Reputation Blacklist.',\

[nerrehmit]

Thank you @fgsch for noticing. I updated the rule you mentioned and verified with grep -ir 'msg:'.*'\.' that this was the only instance of it's kind.

[dune73]

Thank you for the welcome PR @nerrehmit. Travis is failing, but that's not your problem. It's ours.

Also: We shifted the monthly chat by a week. So this will happen on Monday 2030 MET. I'd love to see you in the chat too.

[dune73]

Meeting decision: Will be merged once Travis works again.

#1671 (comment)

[dune73]

Thank you for the update. I looked through the additional commits and everything seems in order.

Merging now.