This repository has been archived by the owner on May 14, 2020. It is now read-only.
Added 'ver' action with current version to all necessary rules (fix for #650) #1750
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #650.
A small footnote for this modification: I generated a spreadsheet for the better visibility of changes.
The column E/F contains the status of actions before, J/K after the modification. The
PL control
is a formula, if theid
of the rule is ended up with...011
,...012
. If it's "yes", thenNeed 'ver' act.
is "no". This means thePL control
rules didn't got thever
action now.Need to add
column is "yes" if the action should be at rule (it's not PL control rule) but there isn't yet. If this is "yes" the script added it.If the rule needs the
ver
and contains it after the modification, then theCheck
field isOK
- but doesn't matter that the action was present or not. All fields must beOK
in this column.The
Changed
fields indicates that a change has been made (was not present before - it present after).Definition of
PL control
:I think this form describes the rules with
skipAfter
actions and doesn't affect exclusion rules. The modification affects all otherSecRule
andSecAction
entries.Let me know if there are still missing any
ver
action, or if it's unnecessary.Note, of course, the modification follows the expected sequence of actions.