Skip to content
This repository has been archived by the owner on May 14, 2020. It is now read-only.

Added 'ver' action with current version to all necessary rules (fix for #650) #1750

Merged
merged 1 commit into from
May 4, 2020

Conversation

airween
Copy link
Contributor

@airween airween commented Apr 29, 2020

This PR fixes #650.

A small footnote for this modification: I generated a spreadsheet for the better visibility of changes.

The column E/F contains the status of actions before, J/K after the modification. The PL control is a formula, if the id of the rule is ended up with ...011, ...012. If it's "yes", then Need 'ver' act. is "no". This means the PL control rules didn't got the ver action now.

Need to add column is "yes" if the action should be at rule (it's not PL control rule) but there isn't yet. If this is "yes" the script added it.

If the rule needs the ver and contains it after the modification, then the Check field is OK - but doesn't matter that the action was present or not. All fields must be OK in this column.

The Changed fields indicates that a change has been made (was not present before - it present after).

Definition of PL control:

id < 1000000 and (id % 1000 >= 100 or id % 1000 <= 10)
  or
id > 1000000

I think this form describes the rules with skipAfter actions and doesn't affect exclusion rules. The modification affects all other SecRule and SecAction entries.

Let me know if there are still missing any ver action, or if it's unnecessary.

Note, of course, the modification follows the expected sequence of actions.

@fzipi
Copy link
Contributor

fzipi commented May 4, 2020

Now that I see this one, shouldn't we use 3.3 as version?

@airween
Copy link
Contributor Author

airween commented May 4, 2020

Now that I see this one, shouldn't we use 3.3 as version?

we've discussed about the version, and the conclusion was we can use the 3.2, as in cas of every other rule.

@fzipi
Copy link
Contributor

fzipi commented May 4, 2020

Cool. So we merge this one, and if we need in the future we update everything to the needed version.

@fzipi fzipi merged commit 8f93d43 into SpiderLabs:v3.3/dev May 4, 2020
@franbuehler
Copy link
Contributor

In the monthly chat meeting from May 4 we decided to merge this PR:
#1749 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent support for the "ver" action
3 participants