Skip to content
This repository has been archived by the owner on May 14, 2020. It is now read-only.

removing Rule 920150, it's redundent #438

Merged
merged 1 commit into from
Aug 9, 2016
Merged

removing Rule 920150, it's redundent #438

merged 1 commit into from
Aug 9, 2016

Conversation

csanders-git
Copy link
Contributor

This pull request deals with rule 920150 as denoted in #437

@csanders-git csanders-git added this to the CRS v3.0.0 RC1 milestone Jul 24, 2016
@csanders-git csanders-git self-assigned this Jul 24, 2016
@dune73
Copy link
Contributor

dune73 commented Jul 25, 2016

Please check my remark in #437 before merging.

@csanders-git csanders-git removed this from the CRS v3.0.0 RC1 milestone Jul 25, 2016
@dune73
Copy link
Contributor

dune73 commented Aug 2, 2016

With the new setup.conf making this very clear, I am open for a merge. If I do not hear objections, I am going to merge.

Btw. we might push a tx.recommended_rules=1 into the official recommended ModSec rules. It would be years before we could depend on it, but it would really be helpful for issues like the one here.

@csanders-git
Copy link
Contributor Author

@dune73 i have no objections, I think at some point we should work on an install script maybe - might look like make where it finds apache and installs to it or nginx etc -- checking that there is a modsecurity.conf default, but this isn't critical as people package this and most people wouldn't need/use it.

@dune73 dune73 merged commit ea843c8 into SpiderLabs:v3.0.0-rc1 Aug 9, 2016
@dune73
Copy link
Contributor

dune73 commented Aug 9, 2016

Sounds like a plan!

lifeforms pushed a commit that referenced this pull request Aug 9, 2016
removing Rule 920150, it's redundent
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants