Skip to content
This repository has been archived by the owner on May 14, 2020. It is now read-only.

Extending CHANGES file #614

Merged
merged 4 commits into from
Oct 15, 2016
Merged

Conversation

dune73
Copy link
Contributor

@dune73 dune73 commented Oct 13, 2016

No description provided.

@dune73 dune73 added this to the CRS v3.0.0 RC2 milestone Oct 13, 2016
(Christina Folini / Walter Hop)
* Shortened overly long RegExes to work on Apache 2.2
* Support for HTTP/2 protocol in request line
* Updated list of webscanners
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm being picky but perhaps just add malicious webscanners

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's more precise. Thanks.

@csanders-git
Copy link
Contributor

Other than my comment it's good except we didn't talk about the fix for Apache 2.2

@dune73
Copy link
Contributor Author

dune73 commented Oct 13, 2016

But we did fix the Apache 2.2 issue, did not we?

@lifeforms
Copy link
Contributor

@dune73 Yes, that's fixed. Just not the Apache < 2.4.11 issue. But as @emphazer said, my cont.py script from #610 can be used to join multiline rules into one rules, so we could put that in util and mention it in the known bugs.

@dune73
Copy link
Contributor Author

dune73 commented Oct 13, 2016

Good plan @lifeforms. Would you mind describing it for KNOWN_BUGS? Either here or in a separate PR.

@lifeforms
Copy link
Contributor

@dune73 I'm tied up at the moment, but I'll add it to your PR #612 tonight.

@emphazer
Copy link
Contributor

@lifeforms i said: theoretical ;-)

@lifeforms
Copy link
Contributor

@emphazer Ow :( Did you actually try it though? I have no old Apaches here so it would take me a lot of time to set it up, but it would be kind of neat if we could officially publish a workaround.

@dune73
Copy link
Contributor Author

dune73 commented Oct 13, 2016

I've got a 2.4.7 laying around in my lab. I could fire it up tonight.

@emphazer
Copy link
Contributor

@lifeforms no, i didnt test it. it was more like a joke because i know that you guys dont like it if someone modifies the ruleset.

the call is still open https://bugzilla.redhat.com/show_bug.cgi?id=1378946

@dune73
Copy link
Contributor Author

dune73 commented Oct 13, 2016

Yeah. The problem with this bug is you have to modify it - or upgrade apache and if that was an option, they would certainly do so.

@emphazer
Copy link
Contributor

emphazer commented Oct 13, 2016

well, found the following working solution

# run 1x this for spaces and tabulators 
sed -i 's@^[\t ]\+@@g' rules/*.conf

# and 2-3x this:
sed -i '{s/[\t ]*$//;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;N;s/,\\\n/,/g;}'  rules/*.conf

it make this rule for example:

SecRule ARGS_NAMES "." \
"phase:request,\
id:921170,\
rev:'2',\
ver:'OWASP_CRS/3.0.0',\
pass,\
nolog,\
tag:'application-multi',\
tag:'platform-multi',\
tag:'attack-protocol',\
tag:'paranoia-level/3',\
tag:'CAPEC-460',\
setvar:'TX.paramcounter_%{MATCHED_VAR_NAME}=+1'"

looks like that

SecRule ARGS_NAMES "." \
"phase:request,id:921170,rev:'2',ver:'OWASP_CRS/3.0.0',pass,nolog,tag:'application-multi',tag:'platform-multi',tag:'attack-protocol',tag:'paranoia-level/3',tag:'CAPEC-460',setvar:'TX.paramcounter_%{MATCHED_VAR_NAME}=+1'"

i tested it with apache 2.4.6

@dune73
Copy link
Contributor Author

dune73 commented Oct 15, 2016

I see this working, but adding it to the KNOWN_BUGS makes the workaround look quirky. I'd say we leave it as is.

@lifeforms
Copy link
Contributor

Added some more stuffs.

@dune73
Copy link
Contributor Author

dune73 commented Oct 15, 2016

So we're done here as well. I'm merging.

@dune73 dune73 merged commit 9683bb3 into SpiderLabs:v3.0.0-rc2 Oct 15, 2016
@dune73 dune73 deleted the dune73-changelog-rc2 branch November 1, 2016 04:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants