-
Notifications
You must be signed in to change notification settings - Fork 727
Conversation
(Christina Folini / Walter Hop) | ||
* Shortened overly long RegExes to work on Apache 2.2 | ||
* Support for HTTP/2 protocol in request line | ||
* Updated list of webscanners |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm being picky but perhaps just add malicious webscanners
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's more precise. Thanks.
Other than my comment it's good except we didn't talk about the fix for Apache 2.2 |
But we did fix the Apache 2.2 issue, did not we? |
Good plan @lifeforms. Would you mind describing it for KNOWN_BUGS? Either here or in a separate PR. |
@lifeforms i said: theoretical ;-) |
@emphazer Ow :( Did you actually try it though? I have no old Apaches here so it would take me a lot of time to set it up, but it would be kind of neat if we could officially publish a workaround. |
I've got a 2.4.7 laying around in my lab. I could fire it up tonight. |
@lifeforms no, i didnt test it. it was more like a joke because i know that you guys dont like it if someone modifies the ruleset. the call is still open https://bugzilla.redhat.com/show_bug.cgi?id=1378946 |
Yeah. The problem with this bug is you have to modify it - or upgrade apache and if that was an option, they would certainly do so. |
well, found the following working solution
it make this rule for example:
looks like that
i tested it with apache 2.4.6 |
I see this working, but adding it to the KNOWN_BUGS makes the workaround look quirky. I'd say we leave it as is. |
Added some more stuffs. |
So we're done here as well. I'm merging. |
No description provided.