Neuropixel: Add mux information to catalogue probes #383
+322
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-mayorquin
changed the title
h-mayorquin
changed the title
h-mayorquin
force-pushed
the
separate_spikeglx_catalogue_from_recording_probe
branch
from
719bd0c to
aa3e2aa
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
get_probe()function from the library does not include MUX information for Neuropixels probes, while the format readers for spikeglx and openephys do. I started working on adding MUX information to the probes obtained withget_probewhen I noticed that the existing code structure made this task more complicated than necessary. To add MUX support to library probes, one would need to either duplicate the construction logic or refactor how_read_imro_string()and recording readers (.e.gread_spikeglx) work together.This PR introduces what I think is cleaner workflow based on a new function called
build_neuropixels_probe(). This function constructs a complete Neuropixels probe from the probe catalogue directly and in full. The new functioncan be used as a stand alone inget_probe()and as the first step on recording readers such as SpikeGLX and OpenEphys (before slicing and adding recording metadata not available in the catalogue). The advantage of this is that we have a single source of truth for Neuropixels probe construction, which simplifies maintenance and future updates.For the sake of the simplicity of the PR I am just changing the spikeglx workflow. Changing the openephys workflow and deprecating functions can be done in a follow up PR if this approach is accepted.