feat: SKILZ-68 - Fix list command issues (4 critical bugs) #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Scanner now uses registry integration instead of hardcoded agents - List command shows Agent column with user-friendly display names - Fixed status logic to use manifest.skill_id for accurate registry lookup - Added --all flag to scan all agents (default: top 5) - Enhanced E2E tests with SKILZ-68 coverage and install verification - Updated unit tests for new functionality - Updated documentation with Agent column and --all flag examples - Fixed type inconsistencies (AgentType -> ExtendedAgentType) Issues resolved: - A: Scanner only finds 2 agents -> now finds 5+ by default, all with --all - B: No Agent column in table -> now shows Agent column with display names - C: Home installs not reliably discovered -> uses registry for proper filtering - D: Status always shows 'unknown' -> uses manifest.skill_id for correct status Tests: 640 passed, 88% coverage, all quality checks passed
- Changed tests to verify scanner logic rather than expecting installed skills - Tests now mock directory scanning to work in clean CI environments - Verify correct agents are scanned using registry instead of hardcoded lists - All tests now pass in both local and CI environments
- Remove unused variable assignments - Organize imports properly - Fix linting errors for CI compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements comprehensive fixes for 4 critical issues in the
skilz listcommand.Issues Resolved
Changes
Testing