feat: improve CLI help discoverability (SKILZ-66) #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Scanner now uses registry integration instead of hardcoded agents - List command shows Agent column with user-friendly display names - Fixed status logic to use manifest.skill_id for accurate registry lookup - Added --all flag to scan all agents (default: top 5) - Enhanced E2E tests with SKILZ-68 coverage and install verification - Updated unit tests for new functionality - Updated documentation with Agent column and --all flag examples - Fixed type inconsistencies (AgentType -> ExtendedAgentType) Issues resolved: - A: Scanner only finds 2 agents -> now finds 5+ by default, all with --all - B: No Agent column in table -> now shows Agent column with display names - C: Home installs not reliably discovered -> uses registry for proper filtering - D: Status always shows 'unknown' -> uses manifest.skill_id for correct status Tests: 640 passed, 88% coverage, all quality checks passed
- Changed tests to verify scanner logic rather than expecting installed skills - Tests now mock directory scanning to work in clean CI environments - Verify correct agents are scanned using registry instead of hardcoded lists - All tests now pass in both local and CI environments
- Remove unused variable assignments - Organize imports properly - Fix linting errors for CI compatibility
- Add comprehensive examples for all commands in main help - Improve command descriptions for better clarity - Add examples for update, remove, read, and config commands - Update list command description to mention agent information - Improve install command description to mention multiple sources This addresses SKILZ-66: --help doesn't show all options/examples - Main help now shows examples for every command - Command descriptions are more descriptive and helpful - All available options are properly documented - Examples demonstrate common usage patterns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses SKILZ-66 by improving the CLI help system to show all available options and comprehensive examples.
Changes Made
Main Help Improvements
Specific Improvements
199-biotechnologies_claude-skill-seo-geo-optimizer/seo-geo-optimizer: unknown (not in registry)
Microck_ordinary-claude-skills/langgraph-docs: up-to-date (76c86cb2)
SpillwaveSolutions_jira/jira: updating 62b3b4c5 -> 54bbda75
Updated: SpillwaveSolutions_jira/jira -> Claude Code (user)
StrayDragon_my-claude-skills/langgraph-python-expert: unknown (not in registry)
Warning: Could not fetch SHA from GitHub (GitHub API error: HTTP 422), will use latest from main
The1Studio_theone-training-skills/docs-seeker: updating 17a31528 -> HEAD
Warning: Could not fetch SHA from GitHub (GitHub API error: HTTP 422), will use latest from main
Updated: The1Studio_theone-training-skills/docs-seeker -> OpenAI Codex (user)
anthropics_skills/algorithmic-art: up-to-date (69c0b1a0)
foreveryh_claude-skills-tutorial/skill-article-publisher: unknown (not in registry)
git/fetch-unresolved-comments: unknown (not in registry)
git/using-spacy-nlp: unknown (not in registry)
netresearch_claude-code-marketplace/cli-tools: updating 07458aef -> 86667a75
Updated: netresearch_claude-code-marketplace/cli-tools -> Claude Code (user)
netresearch_claude-code-marketplace/typo3-docs: updating 07458aef -> 86667a75
Updated: netresearch_claude-code-marketplace/typo3-docs -> Claude Code (user)
thoreinstein_opencode-skills/seo: up-to-date (f7ff2bf7)
Updated 4 skill(s), 3 already up-to-date, 5 not in registry - Update all or specific skills
Setting Config File Env Override Effective
claude_code_home (not set) (not set) /Users/richardh...
open_code_home (not set) (not set) /Users/richardh...
agent_default (not set) (not set) (not set)
Use 'skilz config --init' to create or modify configuration. - Show config and run setup
Agent Skill Version Mode Status
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Claude Code 199-biotechnologies_claude-skill-seo-geo-optimizer/seo-geo-optimizer 3e1c7d8c [copy] unknown
Claude Code Microck_ordinary-claude-skills/langgraph-docs 76c86cb2 [copy] up-to-date
Claude Code SpillwaveSolutions_jira/jira 54bbda75 [copy] up-to-date
Claude Code StrayDragon_my-claude-skills/langgraph-python-expert 6f16da48 [copy] unknown
OpenAI Codex The1Studio_theone-training-skills/docs-seeker 17a31528 [copy] outdated
Claude Code anthropics_skills/algorithmic-art 69c0b1a0 [copy] up-to-date
Claude Code foreveryh_claude-skills-tutorial/skill-article-publisher e124bdd7 [copy] unknown
OpenAI Codex git/fetch-unresolved-comments 283fe80d [copy] unknown
Universal (Skilz) git/fetch-unresolved-comments 283fe80d [copy] unknown
Universal (Skilz) git/running-marketing-campaigns 83fd30b6 [copy] unknown
Universal (Skilz) git/theone-cocos-standards 17a31528 [copy] unknown
Universal (Skilz) git/theone-unity-standards 17a31528 [copy] unknown
Universal (Skilz) git/using-firebase c97c44db [copy] unknown
Claude Code git/using-spacy-nlp d99548b3 [copy] unknown
Claude Code netresearch_claude-code-marketplace/cli-tools 86667a75 [copy] up-to-date
Claude Code netresearch_claude-code-marketplace/typo3-docs 86667a75 [copy] up-to-date
Universal (Skilz) oaustegard_claude-skills/extracting-keywords e8406d38 [copy] outdated
Universal (Skilz) spillwave/plantuml f2489dcd [copy] up-to-date
Claude Code thoreinstein_opencode-skills/seo f7ff2bf7 [copy] up-to-date
Total: 19 skills (19 copied) - List from all agents
Before vs After
Before: Main help was missing examples for 4 major commands
No skills found matching '...'
Checking marketplace: https://skillzwave.ai/skill/...__SKILL/
Opening: https://skillzwave.ai/skill/...__SKILL/
After: Complete coverage with examples for all commands
No skills found matching '...'
Checking marketplace: https://skillzwave.ai/skill/...__SKILL/
Opening: https://skillzwave.ai/skill/...__SKILL/
Impact
Testing