NoReaction instead of Nothing
#1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... because of lack of support of field references in new Validation.
We cannot say "nothing happened" in response to an event, because something indeed happened. So, `NoReaction` is a better way of describing the case when we do not want to react on an event.
…-reaction-etc # Conflicts: # build.gradle.kts # buildSrc/src/main/kotlin/io/spine/internal/dependency/ProtoData.kt # buildSrc/src/main/kotlin/io/spine/internal/dependency/Spine.kt # buildSrc/src/main/kotlin/io/spine/internal/dependency/Validation.kt # config # dependencies.md
alexander-yevsyukov
changed the title
NoReactionNoReaction instead of Nothing
|
@armiol, this PR depends on this version of McJava . |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1554 +/- ##
=========================================
Coverage ? 89.76%
Complexity ? 5022
=========================================
Files ? 646
Lines ? 15747
Branches ? 920
=========================================
Hits ? 14136
Misses ? 1279
Partials ? 332 |
armiol
approved these changes
Oct 10, 2024
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sorts out the matter of "empty" event messages and commands, addressing the issue #1335 and related matters.
New types
The event message type
spine.server.event.NoReactionwas introduced instead ofspine.server.model.Nothing.The command message type
spine.server.command.DoNothingwas introduced instead ofspine.server.model.DoNothing. Old types were deprecated.Previously introduced type aliases
NothingHappenedandNoReactionswere deprecated in favor ofio.spine.server.event.NoReaction.Convenience extensions for returning
EitherOf2EventMessagetype got extension functionsasA()andasB()converting it to corresponding instance ofEitherOf2.