-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newer Base, McJava, ProtoData, and Validation #1558
Conversation
Also: * Force `ProtoData.dogfoodingVersion`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1558 +/- ##
============================================
- Coverage 89.79% 89.77% -0.03%
+ Complexity 5021 5020 -1
============================================
Files 646 646
Lines 15760 15759 -1
Branches 920 920
============================================
- Hits 14152 14147 -5
- Misses 1277 1279 +2
- Partials 331 333 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexander-yevsyukov LGTM. I haven't thoroughly reviewed buildSrc
changes, though. Hopefully, it's the same set of files as in other repos.
This PR applies latest versions of code generation tools to
core-java
. The latestconfig
was also applied, hence the number of modified files.Other notable changes
MatchCriterion
was updated to use binary name of a class instead of a canonical to handle the rare cases of referring methods in anonymous classes (which are sometimes used in tests).AggregateTestSupport
was converted to Kotlin and moved undertestFixtures
.