Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newer Base, McJava, ProtoData, and Validation #1558

Merged
merged 14 commits into from
Nov 26, 2024
Merged

Conversation

alexander-yevsyukov
Copy link
Contributor

@alexander-yevsyukov alexander-yevsyukov commented Nov 24, 2024

This PR applies latest versions of code generation tools to core-java. The latest config was also applied, hence the number of modified files.

Other notable changes

  • The MatchCriterion was updated to use binary name of a class instead of a canonical to handle the rare cases of referring methods in anonymous classes (which are sometimes used in tests).
  • Logging in some tests was muted.
  • AggregateTestSupport was converted to Kotlin and moved under testFixtures.

@alexander-yevsyukov alexander-yevsyukov self-assigned this Nov 24, 2024
@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review November 25, 2024 20:59
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.77%. Comparing base (a6a4c8e) to head (0fdd01d).
Report is 15 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1558      +/-   ##
============================================
- Coverage     89.79%   89.77%   -0.03%     
+ Complexity     5021     5020       -1     
============================================
  Files           646      646              
  Lines         15760    15759       -1     
  Branches        920      920              
============================================
- Hits          14152    14147       -5     
- Misses         1277     1279       +2     
- Partials        331      333       +2     

Copy link
Contributor

@armiol armiol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-yevsyukov LGTM. I haven't thoroughly reviewed buildSrc changes, though. Hopefully, it's the same set of files as in other repos.

@alexander-yevsyukov alexander-yevsyukov merged commit 0a6fa6b into master Nov 26, 2024
7 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the newer-mc-java branch November 26, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants