Do not log thrown Mistake
#1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1561 +/- ##
============================================
- Coverage 89.79% 89.77% -0.03%
+ Complexity 5023 5022 -1
============================================
Files 646 646
Lines 15759 15761 +2
Branches 921 921
============================================
- Hits 14151 14149 -2
- Misses 1276 1280 +4
Partials 332 332 |
alexander-yevsyukov
changed the title
ErrorMistake
|
@armiol, PTAL. |
armiol
requested changes
Dec 15, 2024
| * <p>If {@link #dispatch(SignalEnvelope) dispatching} throws a {@link Mistake} it is rethrown. | ||
| * Other types of exceptions are logged and then rethrown. | ||
| * | ||
| * <p>We treat {@link Error}s differently and want to void much of console output |
There was a problem hiding this comment.
We treat Mistakes differently. Is that what you meant?
|
@alexander-yevsyukov also, the license report check failed. JFYI. |
There's still about |
armiol
requested changes
Dec 15, 2024
| * <p>We treat {@link Mistake}s differently and want to void much of console output | ||
| * for this special case of exceptions. | ||
| * Please see {@link io.spine.server.model.AbstractReceptor#invoke(Object, MessageEnvelope)} | ||
| * for more details on special treatment of {@link Message} during dispatching. |
There was a problem hiding this comment.
Should be
for more details on special treatment of {@link Mistake} during dispatching.
|
@alexander-yevsyukov please see my last comment. It's not addressed yet. |
armiol
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the behaviour of
Bus.doPost()to avoid logging instances ofMistakethrown during dispatching.Also, the code of
AbstractReceptorwas updated to treat catchingMistakein a special way, instead ofError, as was done previously.