Use new Validation package #68
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the codebase to use a new validation package by updating import statements and removing deprecated validation configuration settings. The changes support the transition from the old io.spine.validate package to the new io.spine.validation package structure.
Key changes:
- Updated validation package imports across Java and Kotlin source files
- Removed deprecated validation configuration settings from build files and DSL
- Bumped dependency versions for related Spine framework components
Reviewed changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| version.gradle.kts | Updates core JVM compiler version to align with new validation package |
| tests/rejection/src/test/java/.../RejectionPluginTest.java | Migrates import from old validation package to new one |
| signal/src/main/kotlin/.../RThrowableBuilderCode.kt | Updates validation imports and documentation references |
| routing/src/test/kotlin/.../RouteCompilationTest.kt | Switches to new validation package import |
| gradle-plugins/src/test/kotlin/.../CoreJvmOptionsSpec.kt | Removes obsolete validation version test |
| base/src/main/proto/spine/tools/core/jvm/settings.proto | Removes deprecated validation settings from protobuf schema |
| base/src/main/kotlin/.../ValidationSettings.kt | Deletes entire deprecated validation settings class |
| base/src/main/kotlin/.../CoreJvmCompilerSettings.kt | Removes validation configuration from compiler settings |
| buildSrc files | Updates dependency versions and adds validation module substitution rules |
| tests/*/build.gradle.kts | Removes temporary validation disabling configuration blocks |
| tests/gradlew | Adds environment variable to disable Protobuf version check |
| routing-tests/build.gradle.kts | Adds dependency substitution for old validation bundle module |
| pom.xml | Updates dependency versions across multiple Spine components |
| dependencies.md | Regenerated dependency report with updated versions |
| config | Updates subproject commit reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Warp <agent@warp.dev>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
alexander-yevsyukov
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 33 out of 35 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import io.spine.tools.java.code.methodSpec | ||
| import io.spine.validate.Validate | ||
| import io.spine.validate.Validated | ||
| import io.spine.tools.java.javadoc.JavadocText | ||
| import io.spine.validation.Validated |
There was a problem hiding this comment.
The removed import io.spine.validate.Validate may still be needed if the generated code references Validate.check. Verify that all references to validation functionality use the correct fully-qualified names from the new package.
This PR continues migration to
io.spine.validationpackage. This included also dependency substitution of of old Validation runtime with the new one.CoreJvm Compiler for rejections now uses types from
io.spine.validation.Other notable changes
coreJvm, as they are no longer relevant.tests/gradlewandtests/gradlew.batwere replaced with the symlink files that lead to corresponding scripts in the parent directory.