Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest changes in Spine Storage API #188

Merged
merged 11 commits into from
Nov 9, 2023
Merged

Conversation

armiol
Copy link
Contributor

@armiol armiol commented Nov 9, 2023

This changeset migrates the library code to the changes in RecordSpec and related types, provided in scope of Spine Storage API.

In particular, in this PR the following changes were applied:

  • Usages of Storage API were migrated to new RecordSpec.
  • All common Spine dependencies were updated. Some of them were additionally forced.
  • Recently added grpc-inprocess was also added as a test-implementation-level dependency to whom it concerns.

The library version is set to 2.0.0-SNAPSHOT.174 to match the one of core-java artifacts.

@armiol armiol self-assigned this Nov 9, 2023
@armiol armiol marked this pull request as ready for review November 9, 2023 15:47
@armiol
Copy link
Contributor Author

armiol commented Nov 9, 2023

@alexander-yevsyukov PTAL.

CI builds will pass once core-java#1533 is re-reviewed and merged.

Copy link
Contributor

@alexander-yevsyukov alexander-yevsyukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #188 (219d606) into master (041129f) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #188   +/-   ##
=========================================
  Coverage     87.20%   87.20%           
  Complexity      476      476           
=========================================
  Files            75       75           
  Lines          1813     1813           
  Branches         90       90           
=========================================
  Hits           1581     1581           
  Misses          200      200           
  Partials         32       32           

@armiol armiol added this pull request to the merge queue Nov 9, 2023
Merged via the queue into master with commit 23a9ab8 Nov 9, 2023
5 checks passed
@armiol armiol deleted the update-recordspec-api branch November 9, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants