Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to TemplateString API, and testlib module #173

Merged
merged 14 commits into from
Jan 5, 2025

Conversation

alexander-yevsyukov
Copy link
Contributor

@alexander-yevsyukov alexander-yevsyukov commented Jan 4, 2025

This PR updates the dependency on Validation, migrating to the recently introduced TemplateString API.

Also, the testutil-time module was renamed to spine-testlib to match the naming with testlib artifacts of other Spine SDK libraries.

Changes in details

The method WhenConstraint.errorMessage() now returns TemplateString as required by new Constraint interface API. The method adds the value of the ${field.time} placeholder with the value of the TimeOption.in constraint set on the field.

Build changes

Latest config was applied. Hence the number of modified files.

@alexander-yevsyukov alexander-yevsyukov self-assigned this Jan 4, 2025
@alexander-yevsyukov alexander-yevsyukov marked this pull request as draft January 4, 2025 20:54
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 89.11%. Comparing base (3c6dc55) to head (28732d4).
Report is 15 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #173      +/-   ##
============================================
- Coverage     89.82%   89.11%   -0.71%     
+ Complexity      293      292       -1     
============================================
  Files            53       53              
  Lines           894      900       +6     
  Branches         21       21              
============================================
- Hits            803      802       -1     
- Misses           86       92       +6     
- Partials          5        6       +1     

@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review January 5, 2025 16:18
@alexander-yevsyukov alexander-yevsyukov merged commit 300b55e into master Jan 5, 2025
7 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the testlib-module branch January 5, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants