Fix minor issues with show_entity hover in messages #3908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in hover EntityList does not contain all possible entity types. It does not contain entries for: FishingHook, lightning, Weather, Player, or ComplexPart. Trying to use a hover show entity of one of these types would cause a null pointer exception. And before the previous commit the type was actually the name. Which caused showing entities with a name of "Player" or one of the other types mentioned above to cause this error. Preventing the message from being sent.
zml2008
added
type: bug
|
Thanks! API 7 is EOL but the old Text API is no longer available in API 8+ because we're now using kyori. This looks ok so I guess we can merge it. Note: this is untested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entity name was being used instead of the entity type, causing the type to not be shown to the user unless it happened to be the same as the entity name.
And in some cases such as an entity type (or name, before these changes) being "Player" it would cause an null pointer exception and not send the message at all.