Skip to content

Commit

Permalink
updated release worflow: require manual approval to upload new versio…
Browse files Browse the repository at this point in the history
…n to marketplaces
  • Loading branch information
SpontanCombust committed Aug 5, 2024
1 parent 83c056f commit 3cbe9ff
Showing 1 changed file with 14 additions and 0 deletions.
14 changes: 14 additions & 0 deletions .github/workflows/draft-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ env:
CARGO_TERM_COLOR: always
IS_PRE_RELEASE: ${{ contains(github.ref_name, 'dev') }}

permissions:
issues: write

jobs:
build:
strategy:
Expand Down Expand Up @@ -77,6 +80,17 @@ jobs:
generateReleaseNotes: true
prerelease: ${{ env.IS_PRE_RELEASE }}


- name: Require manual approval to upload the extension to marketplaces
if: ${{ env.IS_PRE_RELEASE == 'false' }}
uses: trstringer/manual-approval@v1
with:
secret: ${{ github.TOKEN }}
approvers: SpontanCombust
minimum-approvals: 1
issue-title: "Deploying ${{ github.ref_name }} to marketplaces from staging"
issue-body: "Please approve or deny the deployment of version ${{ github.ref_name }}."

# The VS Marketplace doesn't yet support pre-release semver versions, sigh....
# https://code.visualstudio.com/api/working-with-extensions/publishing-extension#prerelease-extensions
# - name: Upload extension to VSCode Marketplace (pre-release)
Expand Down

0 comments on commit 3cbe9ff

Please sign in to comment.