ENS lookup in people section #68
Conversation
✅ Deploy Preview for sporosdaoapp-dev canceled.
|
e2e-tests/package.json
Outdated
| @@ -4,8 +4,9 @@ | |||
| "license": "Apache-2.0", | |||
| "scripts": { | |||
| "test": "node src/homepage-dashboard.js", | |||
There was a problem hiding this comment.
Let's update the test target to run all tests:
"test": "node src/*.js"
e2e-tests/package.json
Outdated
| @@ -4,8 +4,9 @@ | |||
| "license": "Apache-2.0", | |||
| "scripts": { | |||
| "test": "node src/homepage-dashboard.js", | |||
| "daoTest": "node src/SporosDaoTest.js", | |||
| "daoTest": "node src/daoTest.js", | |||
There was a problem hiding this comment.
No need to include a yarn target for each test file
e2e-tests/src/ProjectTest.js
Outdated
| @@ -77,11 +77,11 @@ export const flow = { | |||
| }, | |||
| { | |||
| "type": "navigate", | |||
| "url": "http://localhost:3000/", | |||
| "url": "https://deploy-preview-67--sporosdaoapp-dev.netlify.app/", | |||
There was a problem hiding this comment.
The url has to be executable in any local or ci environment. Should not depend on a hardcoded URL.
e2e-tests/src/ProjectTest.js
Outdated
| "assertedEvents": [ | ||
| { | ||
| "type": "navigation", | ||
| "url": "http://localhost:3000/", | ||
| "url": "https://deploy-preview-67--sporosdaoapp-dev.netlify.app/", |
There was a problem hiding this comment.
Same comment as above. Do not use hardcoded URLs. The test is supposed to cover the latest code in the PR.
e2e-tests/src/ProjectTest.js
Outdated
| ] | ||
| ], | ||
| "offsetX": 37, | ||
| "offsetY": 11.1875 | ||
| }, | ||
| { | ||
| "type": "navigate", | ||
| "url": "http://localhost:3000/dao/b32b9ebb-b4b1-4d12-9e55-2aa62178cdf8/projects", | ||
| "url": "https://deploy-preview-67--sporosdaoapp-dev.netlify.app/dao/b32b9ebb-b4b1-4d12-9e55-2aa62178cdf8/projects", |
There was a problem hiding this comment.
Where is the part of the flow that creates this DAO so it is available to test? Remember that all tests should pass in CI or any local dev environment.
There was a problem hiding this comment.
It's impossible to test creating DAO via test script because we cannot mock the metamask sign in the script.
There was a problem hiding this comment.
There are two options here:
- Populate mongodb before running a test then clean up after test run.
- Use metamask e2e extension such as dappeteer:
https://github.com/chainsafe/dappeteer
https://archive.devcon.org/archive/watch/5/make-the-tests-feel-the-users-pain-e2e-testing-for-dapps/?tab=YouTube
e2e-tests/src/daoTest.js
Outdated
| }, | ||
| { | ||
| "type": "navigate", | ||
| "url": "https://deploy-preview-67--sporosdaoapp-dev.netlify.app/", |
There was a problem hiding this comment.
Please do not use hardcoded deployment URL. The test should run against the PR code.
No description provided.