Skip to content

πŸ› Fix: prop-type μ œκ±°ν•˜κ³  jsdoc μ μš©ν•˜κΈ°#155

Merged
aahreum merged 2 commits intomainfrom
fix/profileSelect-jsdoc
Oct 13, 2025
Merged

πŸ› Fix: prop-type μ œκ±°ν•˜κ³  jsdoc μ μš©ν•˜κΈ°#155
aahreum merged 2 commits intomainfrom
fix/profileSelect-jsdoc

Conversation

@eunji0124
Copy link

πŸ”— 이슈 번호

#154

✨ μž‘μ—…ν•œ λ‚΄μš©

ProfileSelect prop-type μ œκ±°ν•˜κ³  jsdoc 적용

@vercel
Copy link

vercel bot commented Oct 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
frontend Ready Ready Preview Comment Oct 13, 2025 7:18am

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @eunji0124, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 ProfileSelect μ»΄ν¬λ„ŒνŠΈμ˜ μ½”λ“œ 가독성과 μœ μ§€λ³΄μˆ˜μ„±μ„ ν–₯μƒμ‹œν‚€κΈ° μœ„ν•΄ prop-types 라이브러리 μ˜μ‘΄μ„±μ„ μ œκ±°ν•˜κ³  JSDoc을 λ„μž…ν•˜μ—¬ μ»΄ν¬λ„ŒνŠΈμ˜ μΈν„°νŽ˜μ΄μŠ€λ₯Ό λͺ…ν™•ν•˜κ²Œ λ¬Έμ„œν™”ν•˜λŠ” 데 쀑점을 λ‘‘λ‹ˆλ‹€. μ΄λŠ” κ°œλ°œμžκ°€ μ»΄ν¬λ„ŒνŠΈμ˜ μ‚¬μš©λ²•μ„ 더 μ‰½κ²Œ 이해할 수 μžˆλ„λ‘ λ•μŠ΅λ‹ˆλ‹€.

Highlights

  • Prop-types 제거: ProfileSelect μ»΄ν¬λ„ŒνŠΈμ—μ„œ 더 이상 prop-types 라이브러리λ₯Ό μ‚¬μš©ν•˜μ§€ μ•Šλ„λ‘ λ³€κ²½λ˜μ—ˆμŠ΅λ‹ˆλ‹€.
  • JSDoc 적용: ProfileSelect μ»΄ν¬λ„ŒνŠΈμ™€ λ‚΄λΆ€ ν•¨μˆ˜μ— JSDoc 주석이 μΆ”κ°€λ˜μ–΄ props와 ν•¨μˆ˜μ˜ λͺ©μ  및 λ§€κ°œλ³€μˆ˜λ₯Ό λͺ…ν™•νžˆ λ¬Έμ„œν™”ν–ˆμŠ΅λ‹ˆλ‹€.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with πŸ‘ and πŸ‘Ž on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@github-actions
Copy link

πŸŽ‰ κ΅¬ν˜„ν•œ κΈ°λŠ₯ Preview: https://frontend-e67w1v4u7-fe-19-seongihuns-projects.vercel.app

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

이번 PR은 ProfileSelect μ»΄ν¬λ„ŒνŠΈμ—μ„œ prop-typesλ₯Ό μ œκ±°ν•˜κ³  JSDoc으둜 λŒ€μ²΄ν•˜λŠ” μž‘μ—…μ„ 잘 μˆ˜ν–‰ν•˜μ…¨μŠ΅λ‹ˆλ‹€. JSDoc을 톡해 νƒ€μž… 정보λ₯Ό λͺ…μ‹œν•˜μ—¬ μ½”λ“œμ˜ 가독성과 μœ μ§€λ³΄μˆ˜μ„±μ„ 높인 점이 μ’‹μŠ΅λ‹ˆλ‹€. JSDoc μŠ€νƒ€μΌ κ°€μ΄λ“œμ™€ κ΄€λ ¨λœ μž‘μ€ κ°œμ„  사항을 ν•œ κ°€μ§€ μ œμ•ˆν•©λ‹ˆλ‹€.

/**
* ν”„λ‘œν•„ 선택 μ»΄ν¬λ„ŒνŠΈ
*
* @param {Object} props - μ»΄ν¬λ„ŒνŠΈ props
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

JSDocμ—μ„œ νƒ€μž…μ„ λͺ…μ‹œν•  λ•Œ Object와 같은 래퍼 객체 νƒ€μž… λŒ€μ‹  object와 같은 μ›μ‹œ νƒ€μž…μ„ μ‚¬μš©ν•˜λŠ” 것이 일반적인 μ»¨λ²€μ…˜μž…λ‹ˆλ‹€. μ΄λ ‡κ²Œ ν•˜λ©΄ λ‹€λ₯Έ μ›μ‹œ νƒ€μž…(예: string, number)과의 일관성을 μœ μ§€ν•  수 μžˆμŠ΅λ‹ˆλ‹€.

Suggested change
* @param {Object} props - μ»΄ν¬λ„ŒνŠΈ props
* @param {object} props - μ»΄ν¬λ„ŒνŠΈ props

@github-actions
Copy link

πŸŽ‰ κ΅¬ν˜„ν•œ κΈ°λŠ₯ Preview: https://frontend-robsw97e7-fe-19-seongihuns-projects.vercel.app

Copy link
Member

@aahreum aahreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€!!

@aahreum aahreum merged commit 31134d3 into main Oct 13, 2025
3 checks passed
@aahreum aahreum deleted the fix/profileSelect-jsdoc branch October 13, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

[πŸ› Bug] prop-type μ œκ±°ν•˜κ³  jsdoc μ μš©ν•˜κΈ°

2 participants