Skip to content

[๐Ÿ› Bug] ํ…์ŠคํŠธ ์—๋””ํ„ฐ ๋‚ด๋ถ€์—์„œ ๊ธ€๊ผด ์ ์šฉํ›„ noto-sans๋กœ ๊ฐ•์ œ๋กœ ๋ฐ”๋€Œ๋Š” ๋ฒ„๊ทธ#157

Merged
aahreum merged 2 commits intomainfrom
feature/Message-Creation-Page
Oct 13, 2025

Conversation

@Greensod-96
Copy link
Contributor

๐Ÿ”— ์ด์Šˆ ๋ฒˆํ˜ธ

โœจ ์ž‘์—…ํ•œ ๋‚ด์šฉ

  • ํ…์ŠคํŠธ ์—๋””ํ„ฐ ๋‚ด๋ถ€์—์„œ ๊ธ€๊ผด ์ ์šฉํ›„ noto-sans๋กœ ๊ฐ•์ œ๋กœ ๋ฐ”๋€Œ๋Š” ๋ฒ„๊ทธ๋ฅผ ํ•ด๊ฒฐํ•˜์˜€์Šต๋‹ˆ๋‹ค.
๋‚˜๋ˆ” ๋‚˜๋ˆ”๋ช…์กฐ

๐Ÿ’ Review Point

๐Ÿ’ก ์ฐธ๊ณ ์‚ฌํ•ญ

@vercel
Copy link

vercel bot commented Oct 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
frontend Ready Ready Preview Comment Oct 13, 2025 9:06am

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Greensod-96, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

์ด PR์€ ํ…์ŠคํŠธ ์—๋””ํ„ฐ์—์„œ ๊ธ€๊ผด์„ ์ ์šฉํ•œ ํ›„ 'Noto Sans'๋กœ ๊ฐ•์ œ๋กœ ๋˜๋Œ์•„๊ฐ€๋Š” ๋ฒ„๊ทธ๋ฅผ ํ•ด๊ฒฐํ•ฉ๋‹ˆ๋‹ค. ์—๋””ํ„ฐ ๋‚ด๋ถ€์˜ ๊ธ€๊ผด ๋ณ€๊ฒฝ ๊ฐ์ง€ ๋กœ์ง์„ ๊ฐœ์„ ํ•˜๊ณ , ์™ธ๋ถ€์—์„œ ์„ ํƒ๋œ ๊ธ€๊ผด๊ณผ ์—๋””ํ„ฐ ๋‚ด๋ถ€์˜ ๊ธ€๊ผด ์ƒํƒœ๋ฅผ ๋” ๊ฒฌ๊ณ ํ•˜๊ฒŒ ๋™๊ธฐํ™”ํ•˜์—ฌ ์‚ฌ์šฉ์ž๊ฐ€ ์„ ํƒํ•œ ๊ธ€๊ผด์ด ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์œ ์ง€๋˜๋„๋ก ํ•ฉ๋‹ˆ๋‹ค.

Highlights

  • ํ…์ŠคํŠธ ์—๋””ํ„ฐ ๊ธ€๊ผด ์œ ์ง€ ๋ฒ„๊ทธ ์ˆ˜์ •: ํ…์ŠคํŠธ ์—๋””ํ„ฐ์—์„œ ๊ธ€๊ผด์„ ์ ์šฉํ•œ ํ›„ 'Noto Sans'๋กœ ๊ฐ•์ œ๋กœ ๋˜๋Œ์•„๊ฐ€๋Š” ๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ์—๋””ํ„ฐ ๋‚ด๋ถ€ ๊ธ€๊ผด ๋ณ€๊ฒฝ ๊ฐ์ง€ ๋กœ์ง ๊ฐœ์„ : Quill ์—๋””ํ„ฐ์˜ ๊ธ€๊ผด ๋ณ€๊ฒฝ ๊ฐ์ง€ ๋กœ์ง์„ selection-change ์ด๋ฒคํŠธ์—์„œ text-change ์ด๋ฒคํŠธ๋กœ ๋ณ€๊ฒฝํ•˜์—ฌ ์‚ฌ์šฉ์ž ์ž…๋ ฅ์— ์˜ํ•œ ๊ธ€๊ผด ๋ณ€๊ฒฝ์„ ๋” ์ •ํ™•ํ•˜๊ฒŒ ๊ฐ์ง€ํ•˜๋„๋ก ๊ฐœ์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ์™ธ๋ถ€ ํฐํŠธ ์„ ํƒ๊ธฐ์™€ ์—๋””ํ„ฐ ๊ฐ„ ์–‘๋ฐฉํ–ฅ ๋™๊ธฐํ™” ๊ฐ•ํ™”: lastSelectionFontRef๋ฅผ ๋„์ž…ํ•˜๊ณ , ํฐํŠธ ๋ณ€๊ฒฝ ํ•ธ๋“ค๋Ÿฌ๋ฅผ ๋ถ„๋ฆฌํ•˜์—ฌ ์—๋””ํ„ฐ์™€ ์™ธ๋ถ€ ๋“œ๋กญ๋‹ค์šด ๊ฐ„์˜ ํฐํŠธ ์ƒํƒœ๊ฐ€ ์ผ๊ด€๋˜๊ฒŒ ์œ ์ง€๋˜๋„๋ก ๋™๊ธฐํ™” ๋ฉ”์ปค๋‹ˆ์ฆ˜์„ ๊ฐ•ํ™”ํ–ˆ์Šต๋‹ˆ๋‹ค.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with ๐Ÿ‘ and ๐Ÿ‘Ž on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. โ†ฉ

@github-actions
Copy link

๐ŸŽ‰ ๊ตฌํ˜„ํ•œ ๊ธฐ๋Šฅ Preview: https://frontend-9p6z45155-fe-19-seongihuns-projects.vercel.app

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

PR์„ ํ†ตํ•ด ํ…์ŠคํŠธ ์—๋””ํ„ฐ์˜ ํฐํŠธ ๊ด€๋ จ ๋ฒ„๊ทธ๋ฅผ ์ˆ˜์ •ํ•ด์ฃผ์…”์„œ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค. selection-change ์ด๋ฒคํŠธ๋ฅผ text-change๋กœ ๋ณ€๊ฒฝํ•˜์—ฌ ์ปค์„œ ์ด๋™ ์‹œ ํฐํŠธ๊ฐ€ ์˜๋„์น˜ ์•Š๊ฒŒ ๋ณ€๊ฒฝ๋˜๋Š” ๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•œ ์ ์ด ์ข‹์Šต๋‹ˆ๋‹ค. ๋‹ค๋งŒ, ์ผ๋ถ€ ํ…์ŠคํŠธ์—๋งŒ ํฐํŠธ๋ฅผ ์ ์šฉํ–ˆ์„ ๋•Œ ๋ฌธ์„œ ์ „์ฒด์˜ ํฐํŠธ๊ฐ€ ๋ณ€๊ฒฝ๋˜๋Š” ์‚ฌ์ด๋“œ ์ดํŽ™ํŠธ๊ฐ€ ์—ฌ์ „ํžˆ ๋‚จ์•„์žˆ์–ด, ์ด๋ฅผ ํ•ด๊ฒฐํ•˜๊ธฐ ์œ„ํ•œ ๋ช‡ ๊ฐ€์ง€ ์ œ์•ˆ์„ ์ฝ”๋“œ ๋ฆฌ๋ทฐ์— ๋‚จ๊ฒผ์Šต๋‹ˆ๋‹ค. ์ œ์•ˆ๋œ ๋‚ด์šฉ์€ ref๋ฅผ ์ถ”๊ฐ€ํ•˜์—ฌ ์—๋””ํ„ฐ ๋‚ด๋ถ€ ๋ณ€๊ฒฝ๊ณผ ์™ธ๋ถ€ ๋ณ€๊ฒฝ์„ ๊ตฌ๋ถ„ํ•˜๋Š” ๋ฐฉ์‹์ž…๋‹ˆ๋‹ค. PostMessage.jsx์˜ ํ•ธ๋“ค๋Ÿฌ ๋ถ„๋ฆฌ ๋กœ์ง์€ ๋ช…ํ™•ํ•˜๊ณ  ์ข‹์•„ ๋ณด์ž…๋‹ˆ๋‹ค.


const TextEditor = ({ value, onChange, onFontChange, font }) => {
const reactQuillRef = useRef(null);
const lastSelectionFontRef = useRef(null); // ๋งˆ์ง€๋ง‰ ์„ ํƒ ์˜์—ญ์˜ ํฐํŠธ ์ถ”์ 
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

ํฐํŠธ ๋ณ€๊ฒฝ ๋กœ์ง ๊ฐœ์„ ์„ ์œ„ํ•œ ref ์ถ”๊ฐ€ ์ œ์•ˆ์ž…๋‹ˆ๋‹ค. ํ˜„์žฌ ๊ตฌํ˜„์€ ์—๋””ํ„ฐ ๋‚ด๋ถ€์—์„œ ํฐํŠธ๋ฅผ ๋ณ€๊ฒฝํ•  ๋•Œ ๋ฌธ์„œ ์ „์ฒด์— ํฐํŠธ๊ฐ€ ์ ์šฉ๋˜๋Š” ์‚ฌ์ด๋“œ ์ดํŽ™ํŠธ๋ฅผ ์ผ์œผํ‚ฌ ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค. ์ด๋ฅผ ๋ฐฉ์ง€ํ•˜๊ธฐ ์œ„ํ•ด, ์—๋””ํ„ฐ ๋‚ด๋ถ€์—์„œ ๋ฐœ์ƒํ•œ ๋ณ€๊ฒฝ์ธ์ง€๋ฅผ ์ถ”์ ํ•˜๋Š” ref๋ฅผ ์ถ”๊ฐ€ํ•˜๋Š” ๊ฒƒ์ด ์ข‹์Šต๋‹ˆ๋‹ค. ์ด ref๋Š” ์ด์–ด์ง€๋Š” ๋‹ค๋ฅธ ์ œ์•ˆ๋“ค์—์„œ ์‚ฌ์šฉ๋ฉ๋‹ˆ๋‹ค.

Suggested change
const lastSelectionFontRef = useRef(null); // ๋งˆ์ง€๋ง‰ ์„ ํƒ ์˜์—ญ์˜ ํฐํŠธ ์ถ”์ 
const lastSelectionFontRef = useRef(null); // ๋งˆ์ง€๋ง‰ ์„ ํƒ ์˜์—ญ์˜ ํฐํŠธ ์ถ”์ 
const isInternalChangeRef = useRef(false); // ์—๋””ํ„ฐ ๋‚ด๋ถ€ ํฐํŠธ ๋ณ€๊ฒฝ ์—ฌ๋ถ€ ์ถ”์ 

Comment on lines +237 to 240
if (format.font && format.font !== lastSelectionFontRef.current) {
lastSelectionFontRef.current = format.font;
onFontChange(format.font);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

์—๋””ํ„ฐ ๋‚ด๋ถ€์—์„œ ํฐํŠธ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ์„ ๋•Œ, onFontChange๋ฅผ ํ˜ธ์ถœํ•˜๊ธฐ ์ „์— isInternalChangeRef ํ”Œ๋ž˜๊ทธ๋ฅผ true๋กœ ์„ค์ •ํ•ด์•ผ ํ•ฉ๋‹ˆ๋‹ค. ์ด๋ ‡๊ฒŒ ํ•˜๋ฉด ๋ถ€๋ชจ ์ปดํฌ๋„ŒํŠธ๋กœ๋ถ€ํ„ฐ font prop์ด ์—…๋ฐ์ดํŠธ๋˜์–ด๋„, ์•ž์—์„œ ์ˆ˜์ •ํ•œ useEffect๊ฐ€ ์ „์ฒด ํฐํŠธ ์ ์šฉ ๋กœ์ง์„ ์‹คํ–‰ํ•˜๋Š” ๊ฒƒ์„ ๋ง‰์„ ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.

      if (format.font && format.font !== lastSelectionFontRef.current) {
        isInternalChangeRef.current = true; // ๋‚ด๋ถ€ ๋ณ€๊ฒฝ ํ”Œ๋ž˜๊ทธ ์„ค์ •
        lastSelectionFontRef.current = format.font;
        onFontChange(format.font);
      }

Copy link
Member

@aahreum aahreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

@aahreum aahreum merged commit 873119c into main Oct 13, 2025
3 checks passed
@aahreum aahreum deleted the feature/Message-Creation-Page branch October 13, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

2 participants