Skip to content

๐Ÿ› Fix: ๋กœ๋”ฉ์ค‘ ๋””์ž์ธ ์ˆ˜์ •#166

Merged
aahreum merged 1 commit intomainfrom
fix/loading
Oct 13, 2025
Merged

๐Ÿ› Fix: ๋กœ๋”ฉ์ค‘ ๋””์ž์ธ ์ˆ˜์ •#166
aahreum merged 1 commit intomainfrom
fix/loading

Conversation

@heoc0523
Copy link
Contributor

๐Ÿ”— ์ด์Šˆ ๋ฒˆํ˜ธ

โœจ ์ž‘์—…ํ•œ ๋‚ด์šฉ

MobilePaperList์˜ ๋กœ๋”ฉ ์ƒํƒœ๋ฅผ skeleton UI๋กœ ๋ณ€๊ฒฝ

@vercel
Copy link

vercel bot commented Oct 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
frontend Ready Ready Preview Comment Oct 13, 2025 2:50pm

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @heoc0523, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

์ด Pull Request๋Š” MobilePaperList ์ปดํฌ๋„ŒํŠธ์˜ ๋กœ๋”ฉ ์ƒํƒœ ๋””์ž์ธ์„ ๊ฐœ์„ ํ•˜๋Š” ๊ฒƒ์„ ๋ชฉํ‘œ๋กœ ํ•ฉ๋‹ˆ๋‹ค. ์‚ฌ์šฉ์ž ๊ฒฝํ—˜์„ ํ–ฅ์ƒ์‹œํ‚ค๊ธฐ ์œ„ํ•ด ๋‹จ์ˆœ ํ…์ŠคํŠธ ๋กœ๋”ฉ ๋ฉ”์‹œ์ง€ ๋Œ€์‹  ์‹œ๊ฐ์ ์œผ๋กœ ๋” ๋ถ€๋“œ๋Ÿฌ์šด ์Šค์ผˆ๋ ˆํ†ค UI๋ฅผ ๋„์ž…ํ•˜์—ฌ, ๋ฐ์ดํ„ฐ๊ฐ€ ๋กœ๋“œ๋˜๋Š” ๋™์•ˆ ์‚ฌ์šฉ์ž์—๊ฒŒ ๋” ๋‚˜์€ ์‹œ๊ฐ์  ํ”ผ๋“œ๋ฐฑ์„ ์ œ๊ณตํ•ฉ๋‹ˆ๋‹ค.

Highlights

  • ๋กœ๋”ฉ UI ๊ฐœ์„ : MobilePaperList ์ปดํฌ๋„ŒํŠธ์—์„œ ๋ฐ์ดํ„ฐ ๋กœ๋”ฉ ์ค‘ ํ‘œ์‹œ๋˜๋Š” UI๋ฅผ ๊ธฐ์กด์˜ ํ…์ŠคํŠธ("๋กœ๋”ฉ ์ค‘...")์—์„œ ์Šค์ผˆ๋ ˆํ†ค UI(RollingPaperCardSkeleton)๋กœ ๋ณ€๊ฒฝํ–ˆ์Šต๋‹ˆ๋‹ค.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with ๐Ÿ‘ and ๐Ÿ‘Ž on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. โ†ฉ

@github-actions
Copy link

๐ŸŽ‰ ๊ตฌํ˜„ํ•œ ๊ธฐ๋Šฅ Preview: https://frontend-ijumkk5h0-fe-19-seongihuns-projects.vercel.app

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

์•ˆ๋…•ํ•˜์„ธ์š”. ๋กœ๋”ฉ ์ค‘ ์ƒํƒœ๋ฅผ ํ…์ŠคํŠธ์—์„œ ์Šค์ผˆ๋ ˆํ†ค UI๋กœ ๋ณ€๊ฒฝํ•˜์—ฌ ์‚ฌ์šฉ์ž ๊ฒฝํ—˜์„ ๊ฐœ์„ ํ•œ ์ ์ด ์ข‹์Šต๋‹ˆ๋‹ค. ์ฝ”๋“œ ๊ฐ€๋…์„ฑ๊ณผ ์œ ์ง€๋ณด์ˆ˜์„ฑ์„ ๋†’์ด๊ธฐ ์œ„ํ•ด ํ•œ ๊ฐ€์ง€ ์ œ์•ˆ ์‚ฌํ•ญ์„ ๋‚จ๊น๋‹ˆ๋‹ค.

Comment on lines +46 to +48
LIST_LIMIT_ARRAY.slice(0, 2).map((_, idx) => {
return <RollingPaperCardSkeleton key={`fetch-${idx}`} />;
})}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

์ถ”๊ฐ€ ๋ฐ์ดํ„ฐ ๋กœ๋”ฉ ์‹œ ๋ณด์—ฌ์ค„ ์Šค์ผˆ๋ ˆํ†ค UI ๊ฐœ์ˆ˜๋ฅผ LIST_LIMIT_ARRAY.slice(0, 2)๋ฅผ ํ†ตํ•ด ์ œ์–ดํ•˜๊ณ  ๊ณ„์‹ญ๋‹ˆ๋‹ค. ์ด ๋ฐฉ๋ฒ•์€ LIST_LIMIT ์ƒ์ˆ˜์— ์˜์กด์„ฑ์„ ๊ฐ–๊ฒŒ ๋˜์–ด, ๋งŒ์•ฝ LIST_LIMIT ๊ฐ’์ด 2 ๋ฏธ๋งŒ์œผ๋กœ ๋ณ€๊ฒฝ๋  ๊ฒฝ์šฐ ์˜๋„์™€ ๋‹ค๋ฅด๊ฒŒ 2๊ฐœ๋ณด๋‹ค ์ ์€ ์Šค์ผˆ๋ ˆํ†ค์ด ๋ Œ๋”๋ง๋  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.

ํ•ญ์ƒ 2๊ฐœ์˜ ์Šค์ผˆ๋ ˆํ†ค์„ ํ‘œ์‹œํ•˜๋Š” ๊ฒƒ์ด ๋ชฉ์ ์ด๋ผ๋ฉด, Array.from({ length: 2 })๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ LIST_LIMIT์˜ ๋ณ€๊ฒฝ๊ณผ ๋ฌด๊ด€ํ•˜๊ฒŒ ํ•ญ์ƒ 2๊ฐœ์˜ ์š”์†Œ๋ฅผ ๊ฐ€์ง„ ๋ฐฐ์—ด์„ ์ƒ์„ฑํ•˜๋Š” ๊ฒƒ์ด ๋” ๋ช…ํ™•ํ•˜๊ณ  ์•ˆ์ „ํ•œ ๋ฐฉ๋ฒ•์ž…๋‹ˆ๋‹ค.

        Array.from({ length: 2 }).map((_, idx) => {
          return <RollingPaperCardSkeleton key={`fetch-${idx}`} />;
        })

Copy link
Member

@aahreum aahreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!!!

@aahreum aahreum merged commit b190852 into main Oct 13, 2025
3 checks passed
@aahreum aahreum deleted the fix/loading branch October 13, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants