Skip to content

πŸ› Bug: λͺ¨λ‹¬, λ©”μ„Έμ§€μΉ΄λ“œ μ»€μ„œ 버그#172

Merged
aahreum merged 4 commits intomainfrom
fix/modal-massgecard-cursor
Oct 14, 2025
Merged

πŸ› Bug: λͺ¨λ‹¬, λ©”μ„Έμ§€μΉ΄λ“œ μ»€μ„œ 버그#172
aahreum merged 4 commits intomainfrom
fix/modal-massgecard-cursor

Conversation

@Greensod-96
Copy link
Contributor

πŸ”— 이슈 번호

✨ μž‘μ—…ν•œ λ‚΄μš©

  • μΉ΄λ“œμ—μ„œλŠ” cursor-pointer, λͺ¨λ‹¬μ—μ„œλŠ” cursor-default ν˜•νƒœλ‘œ κ΅¬ν˜„μ™„λ£Œ.
사진ㅇ 사진ㅇㅇ

πŸ’ Review Point

πŸ’‘ 참고사항

@vercel
Copy link

vercel bot commented Oct 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
frontend Ready Ready Preview Comment Oct 14, 2025 6:42am

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Greensod-96, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 λ©”μ‹œμ§€ μΉ΄λ“œμ™€ λͺ¨λ‹¬ κ°„μ˜ 일관성 μ—†λŠ” μ»€μ„œ λ™μž‘μ„ ν•΄κ²°ν•˜μ—¬ μ‚¬μš©μž κ²½ν—˜μ„ κ°œμ„ ν•©λ‹ˆλ‹€. λ©”μ‹œμ§€ μΉ΄λ“œμ—μ„œλŠ” μƒν˜Έμž‘μš©μ„ λ‚˜νƒ€λ‚΄λŠ” 포인터 μ»€μ„œλ₯Ό, λͺ¨λ‹¬μ—μ„œλŠ” μ½˜ν…μΈ  보기λ₯Ό μœ„ν•œ κΈ°λ³Έ μ»€μ„œλ₯Ό μ μš©ν•˜λ„λ‘ UIλ₯Ό μ‘°μ •ν–ˆμŠ΅λ‹ˆλ‹€.

Highlights

  • μ»€μ„œ 버그 μˆ˜μ •: λ©”μ‹œμ§€ μΉ΄λ“œμ™€ λͺ¨λ‹¬μ—μ„œ μ»€μ„œκ°€ μ˜¬λ°”λ₯΄κ²Œ ν‘œμ‹œλ˜μ§€ μ•Šλ˜ 버그λ₯Ό μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€. 이제 λ©”μ‹œμ§€ μΉ΄λ“œμ—μ„œλŠ” 'pointer' μ»€μ„œκ°€, λͺ¨λ‹¬μ—μ„œλŠ” 'default' μ»€μ„œκ°€ ν‘œμ‹œλ©λ‹ˆλ‹€.
  • PostContent μ»΄ν¬λ„ŒνŠΈ κ°œμ„ : PostContent μ»΄ν¬λ„ŒνŠΈμ— 'card' prop을 μΆ”κ°€ν•˜μ—¬, μΉ΄λ“œ 뷰와 λͺ¨λ‹¬ 뷰에 따라 μ»€μ„œ μŠ€νƒ€μΌκ³Ό ν…μŠ€νŠΈ 선택 κ°€λŠ₯ μ—¬λΆ€λ₯Ό λ™μ μœΌλ‘œ μ œμ–΄ν•  수 μžˆλ„λ‘ ν–ˆμŠ΅λ‹ˆλ‹€.
  • CSS 클래슀 μΆ”κ°€: μ»€μ„œ μŠ€νƒ€μΌμ„ κ°•μ œν•˜κΈ° μœ„ν•œ .pointer-mode 및 .default-mode CSS 클래슀λ₯Ό quill-custom.css νŒŒμΌμ— μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with πŸ‘ and πŸ‘Ž on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@github-actions
Copy link

πŸŽ‰ κ΅¬ν˜„ν•œ κΈ°λŠ₯ Preview: https://frontend-ogl9g1pui-fe-19-seongihuns-projects.vercel.app

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

이번 PR은 λͺ¨λ‹¬κ³Ό λ©”μ‹œμ§€ μΉ΄λ“œμ—μ„œ λ°œμƒν•˜λŠ” μ»€μ„œ 버그λ₯Ό μˆ˜μ •ν•˜λŠ” 것을 λͺ©ν‘œλ‘œ ν•˜κ³  μžˆμŠ΅λ‹ˆλ‹€. μ „λ°˜μ μœΌλ‘œ μ˜¬λ°”λ₯Έ λ°©ν–₯으둜 μˆ˜μ •μ΄ μ΄λ£¨μ–΄μ‘ŒμŠ΅λ‹ˆλ‹€. PostContent μ»΄ν¬λ„ŒνŠΈμ—μ„œ card prop에 따라 μ‘°κ±΄λΆ€λ‘œ CSS 클래슀λ₯Ό μ μš©ν•˜μ—¬ μ»€μ„œ μŠ€νƒ€μΌμ„ μ œμ–΄ν•˜λŠ” 방식은 쒋은 μ ‘κ·Όμž…λ‹ˆλ‹€. λ˜ν•œ user-select μŠ€νƒ€μΌμ„ μΆ”κ°€ν•˜μ—¬ μΉ΄λ“œ μœ„μ—μ„œ ν…μŠ€νŠΈκ°€ μ„ νƒλ˜μ§€ μ•Šλ„λ‘ ν•œ 점도 쒋은 μ‚¬μš©μž κ²½ν—˜ κ°œμ„ μž…λ‹ˆλ‹€.

λ‹€λ§Œ, 일뢀 μ½”λ“œμ—μ„œ μ€‘λ³΅λ˜κ±°λ‚˜ λΆˆν•„μš”ν•œ 뢀뢄이 μžˆμ–΄ λͺ‡ κ°€μ§€ κ°œμ„ μ μ„ μ œμ•ˆν•©λ‹ˆλ‹€. MessageCard μ»΄ν¬λ„ŒνŠΈμ˜ λΆˆν•„μš”ν•œ useEffect 훅을 μ œκ±°ν•˜κ³ , μ€‘λ³΅λ˜λŠ” CSS 클래슀λ₯Ό μ •λ¦¬ν•˜λ©΄ μ½”λ“œκ°€ 더 κΉ”λ”ν•˜κ³  μœ μ§€λ³΄μˆ˜ν•˜κΈ° μ’‹μ•„μ§ˆ κ²ƒμž…λ‹ˆλ‹€. μžμ„Έν•œ λ‚΄μš©μ€ 각 νŒŒμΌμ— 남긴 주석을 μ°Έκ³ ν•΄μ£Όμ„Έμš”.

Comment on lines +70 to +72
className={`ql-editor w-full ${textStyle(font)} ${quillFontClass} ${className} ${
card ? 'pointer-mode cursor-pointer' : 'default-mode cursor-default'
}`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

pointer-mode와 default-mode ν΄λž˜μŠ€κ°€ 각각 cursor: pointer !important와 cursor: default !importantλ₯Ό μ μš©ν•˜λ―€λ‘œ, cursor-pointer와 cursor-default ν΄λž˜μŠ€λŠ” μ€‘λ³΅λ©λ‹ˆλ‹€. μ½”λ“œλ₯Ό 더 κ°„κ²°ν•˜κ²Œ λ§Œλ“€κΈ° μœ„ν•΄ μ€‘λ³΅λ˜λŠ” 클래슀λ₯Ό μ œκ±°ν•˜λŠ” 것이 μ’‹μŠ΅λ‹ˆλ‹€.

Suggested change
className={`ql-editor w-full ${textStyle(font)} ${quillFontClass} ${className} ${
card ? 'pointer-mode cursor-pointer' : 'default-mode cursor-default'
}`}
className={`ql-editor w-full ${textStyle(font)} ${quillFontClass} ${className} ${
card ? 'pointer-mode' : 'default-mode'
}`}

Comment on lines +49 to +57
useEffect(() => {
if (!cardRef.current) {
return;
}
const editor = cardRef.current.querySelector('.ql-editor');
if (editor) {
editor.style.cursor = 'pointer';
}
}, [content]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

이 useEffect 훅은 λΆˆν•„μš”ν•΄ λ³΄μž…λ‹ˆλ‹€. PostContent μ»΄ν¬λ„ŒνŠΈλŠ” card prop이 true일 λ•Œ pointer-mode 클래슀λ₯Ό λ‚΄λΆ€μ μœΌλ‘œ μ μš©ν•˜μ—¬ μ»€μ„œ μŠ€νƒ€μΌμ„ 이미 μ²˜λ¦¬ν•˜κ³  μžˆμŠ΅λ‹ˆλ‹€. pointer-modeλŠ” cursor: pointer !importantλ₯Ό λͺ¨λ“  ν•˜μœ„ μš”μ†Œμ— μ μš©ν•˜λ―€λ‘œ, 이 useEffectλ₯Ό ν†΅ν•œ 직접적인 DOM μ‘°μž‘μ€ μ€‘λ³΅λ©λ‹ˆλ‹€.

μ½”λ“œλ₯Ό 더 κ°„κ²°ν•˜κ²Œ μœ μ§€ν•˜κ³  직접적인 DOM μ‘°μž‘μ„ ν”Όν•˜κΈ° μœ„ν•΄ λ‹€μŒμ„ μ œκ±°ν•˜λŠ” 것이 μ’‹μŠ΅λ‹ˆλ‹€:

  • 이 useEffect ν›… (lines 49-57)
  • cardRef μ„ μ–Έ (line 35)
  • div μš”μ†Œμ˜ ref={cardRef} 속성 (line 61)
  • reactμ—μ„œ useEffect와 useRef import (line 1)

<PostContent
htmlContent={content}
className={'line-clamp-2 sm:line-clamp-3'}
className="line-clamp-2 cursor-pointer sm:line-clamp-3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

PostContent μ»΄ν¬λ„ŒνŠΈμ— card prop이 true둜 μ „λ‹¬λ˜λ©΄, λ‚΄λΆ€μ μœΌλ‘œ pointer-mode ν΄λž˜μŠ€κ°€ μ μš©λ©λ‹ˆλ‹€. 이 ν΄λž˜μŠ€λŠ” cursor: pointer !important μŠ€νƒ€μΌμ„ λͺ¨λ“  ν•˜μœ„ μš”μ†Œμ— μ μš©ν•˜λ―€λ‘œ, μ—¬κΈ°μ„œ cursor-pointer 클래슀λ₯Ό μΆ”κ°€λ‘œ 전달할 ν•„μš”κ°€ μ—†μŠ΅λ‹ˆλ‹€. 쀑볡을 μ œκ±°ν•˜κΈ° μœ„ν•΄ 이 클래슀λ₯Ό μ‚­μ œν•˜λŠ” 것이 μ’‹μŠ΅λ‹ˆλ‹€.

Suggested change
className="line-clamp-2 cursor-pointer sm:line-clamp-3"
className="line-clamp-2 sm:line-clamp-3"

Copy link
Member

@aahreum aahreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€!!!!!!!!!!

@aahreum aahreum merged commit 40576ee into main Oct 14, 2025
3 checks passed
@aahreum aahreum deleted the fix/modal-massgecard-cursor branch October 14, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

[πŸ› Bug] λͺ¨λ‹¬, λ©”μ„Έμ§€μΉ΄λ“œ μ»€μ„œ 버그

2 participants