Enabled nullable in the entire project and removed explicit #nullable…

… statements
SpryFox · Sep 2, 2024 · 2f1a90c · 2f1a90c
1 parent b841aec
commit 2f1a90c
Show file tree

Hide file tree

Showing 21 changed files with 4 additions and 42 deletions.
diff --git a/src/DarkConfig/Attributes.cs b/src/DarkConfig/Attributes.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 using System;
 
 namespace DarkConfig {

diff --git a/src/DarkConfig/ConfigFileInfo.cs b/src/DarkConfig/ConfigFileInfo.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 using System;
 
 namespace DarkConfig {

diff --git a/src/DarkConfig/ConfigProcessor.cs b/src/DarkConfig/ConfigProcessor.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 namespace DarkConfig {
     /// Processors can modify DocNodes after being parsed from YAML, but before used by the rest of the systems
     /// Note: this is ONLY run on the YAML -> DocNode path, any other DocNode creation is not affected

diff --git a/src/DarkConfig/ConfigSource.cs b/src/DarkConfig/ConfigSource.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 using System.Collections;
 using System.Collections.Generic;
 using System.Linq;

diff --git a/src/DarkConfig/Configs.cs b/src/DarkConfig/Configs.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 using System;
 using System.Collections;
 using System.IO;

diff --git a/src/DarkConfig/DarkConfig.csproj b/src/DarkConfig/DarkConfig.csproj
@@ -1,12 +1,13 @@
 <Project Sdk="Microsoft.NET.Sdk">
 	<PropertyGroup>
+		<!-- These need to match what Unity is using! -->
 		<TargetFramework>net6.0</TargetFramework>
-		<ImplicitUsings>disable</ImplicitUsings>
-		<Nullable>disable</Nullable>
+		<LangVersion>9</LangVersion>
 
+		<ImplicitUsings>disable</ImplicitUsings>
+		<Nullable>enable</Nullable>
 		<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
 		<OutputPath>..\..\bin\$(Configuration)</OutputPath>
-		<LangVersion>9</LangVersion>
 	</PropertyGroup>
 
 	<ItemGroup>

diff --git a/src/DarkConfig/DocNode/ComposedDocNode.cs b/src/DarkConfig/DocNode/ComposedDocNode.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 using System;
 using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;

diff --git a/src/DarkConfig/DocNode/DocNode.cs b/src/DarkConfig/DocNode/DocNode.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 using System;
 using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;

diff --git a/src/DarkConfig/DocNode/YamlDocNode.cs b/src/DarkConfig/DocNode/YamlDocNode.cs
@@ -1,4 +1,3 @@
-#nullable enable
 using System;
 using System.Collections;
 using System.Collections.Generic;

diff --git a/src/DarkConfig/Exceptions.cs b/src/DarkConfig/Exceptions.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 using System;
 using System.IO;
 

diff --git a/src/DarkConfig/FileSource.cs b/src/DarkConfig/FileSource.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 using System;
 using System.Collections;
 using System.IO;

diff --git a/src/DarkConfig/Internal/BuiltInTypeReifiers.cs b/src/DarkConfig/Internal/BuiltInTypeReifiers.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 using System;
 
 namespace DarkConfig.Internal {

diff --git a/src/DarkConfig/Internal/ChecksumUtils.cs b/src/DarkConfig/Internal/ChecksumUtils.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 using System.IO;
 
 namespace DarkConfig.Internal {

diff --git a/src/DarkConfig/Internal/ConfigFileManager.cs b/src/DarkConfig/Internal/ConfigFileManager.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 using System;
 using System.Collections;
 using System.Collections.Generic;

diff --git a/src/DarkConfig/Internal/DocumentationGenerator.cs b/src/DarkConfig/Internal/DocumentationGenerator.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 using System;
 using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;

diff --git a/src/DarkConfig/Internal/MultiCaseDictionary.cs b/src/DarkConfig/Internal/MultiCaseDictionary.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 using System;
 using System.Collections;
 using System.Collections.Generic;

diff --git a/src/DarkConfig/Internal/ReflectionCache.cs b/src/DarkConfig/Internal/ReflectionCache.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 using System;
 using System.Collections.Generic;
 using System.Reflection;

diff --git a/src/DarkConfig/Internal/RegexUtils.cs b/src/DarkConfig/Internal/RegexUtils.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 using System.Collections.Generic;
 using System.Text.RegularExpressions;
 

diff --git a/src/DarkConfig/Internal/StringExtensions.cs b/src/DarkConfig/Internal/StringExtensions.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 namespace DarkConfig.Internal {
     static class StringExtensions {
         /// Returns the lowercase version of the key if <c>ignoreCase</c>, otherwise return the key itself

diff --git a/src/DarkConfig/Internal/TypeReifier.cs b/src/DarkConfig/Internal/TypeReifier.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 using System;
 using System.Collections.Generic;
 using System.Linq;

diff --git a/src/DarkConfig/Settings.cs b/src/DarkConfig/Settings.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 using System;
 
 namespace DarkConfig {