75 unit test testcurrentorfutureriskcalculation

[panositi]

Merged 75 unit test testcurrentorfutureriskcalculation-1 but needs further checks, src/test/resources/modelvalidator/RiskLevelCalculator contains all DM, SM required for unit tests. Needs further testing.

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[scp93ch]

Please look at the code smell on line 431 (the String.format, not the throwing of a RuntimeException).

Also remove the lines where the @ignore is now commented.

Why are there two system model files now not loaded (commented out) in src/test/java/uk/ac/soton/itinnovation/security/modelvalidator/test/RiskLevelCalculatorTester.java ? If we really do not need them then delete the lines and delete the files.

[mike1813]

@panositi : it looks like @scp93ch asked you to make changes. As far as I can tell they were not done. Please can you take some action to resolve this?

[kenmeacham]

@panositi - there seems to be two open branches for this issue, both with code changes/commits, although your comment above seems to suggest that you merged testcurrentorfutureriskcalculation-1?

Can you clarify which branches are still active/required?

• 75-unit-test-testcurrentorfutureriskcalculation
• 75-unit-test-testcurrentorfutureriskcalculation-1

[kenmeacham]

@panositi - also this pull request tells us there are some conflicts which should be resolved.