Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronous code signing #1278

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jonoomph
Copy link

Switching the Releasify method to code sign files in a synchronous method (as opposed to async). For larger projects, with more than 130 signable files, the async handling of this causes lots of deadlocks and freezes in our docker build image.

This simplified, synchronous version works awesome, has no freezes or deadlocks, and in our testing (with lots of signable files) actually completes faster than the previous async version. Go figure. =)

@jonoomph jonoomph closed this Mar 23, 2018
@jonoomph
Copy link
Author

Needs another small adjustment first

@anaisbetts anaisbetts reopened this Mar 23, 2018
@anaisbetts
Copy link
Contributor

Just push more commits, you don't need to close this PR

@anaisbetts
Copy link
Contributor

Also, you can really just set the concurrency factor of ForEachAsync to 1, and also, please match the style

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants