You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a new, clean Pull Request for the first phase of the Floating Action Button feature. The original PR, #49 , was closed due to a stale and confusing diff on GitHub.
This is the first of three planned pull requests to implement the new Floating Action Button (FAB) feature, as discussed in the comments.
This foundational PR includes:
A new EmergencyFab.tsx component.
The core FAB with a functional expand/collapse state (isOpen).
A simple vertical menu of the three action buttons.
Full compatibility with the project's Dark/Light mode theme.
Bonus: Removed an unused api import and function from the Dashboard for better code health.
This PR intentionally does not include animations or tooltips, as those will be handled in PR #2.
Hi @SrinjoyeeDey,
Hope you're having a wonderful week!
Just wanted to gently follow up on this new PR. I'm really excited to move on to the next phase (animations and tooltips) as per our plan.
Please let me know if there's anything else you need from me to get this foundational part merged.
Thank you!"
Hi @SrinjoyeeDey,
Hope you're having a productive week!
I'm just checking in on this PR one last time. With the Hacktoberfest deadline getting closer, I'm really hoping to complete all three planned PRs for this feature before the end of the month.
Of course, I can't start on PR #2 until this foundational part is merged. Is there any feedback I can address to help get this PR ready for merging?
I'm ready to make any necessary changes immediately. Thank you!
HI @SrinjoyeeDey
Are there any changes required from my end to merge the PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (PR 1 of 3)
This is a new, clean Pull Request for the first phase of the Floating Action Button feature. The original PR, #49 , was closed due to a stale and confusing diff on GitHub.
This is the first of three planned pull requests to implement the new Floating Action Button (FAB) feature, as discussed in the comments.
This foundational PR includes:
EmergencyFab.tsxcomponent.isOpen).apiimport and function from the Dashboard for better code health.This PR intentionally does not include animations or tooltips, as those will be handled in PR #2.
Related Issue
Screenshots
Desktop View:
Mobile View (Expanded Menu):
