Skip to content

Simplify type checking in sort_collections() Closes https://github.com/StackGuardian/tirith/issues/185 #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

gabrilito1
Copy link
Contributor

Update the sort_collections function in the utils.py to use a single isinstance check for primitive types.

Copy link
Member

@refeed refeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gabrilito1 , thanks this looks good.

Only a few minor things though:

  1. Could you fix the linting warnings by running black in your system?
  2. Could you make your commit message into:
Simplify type checking in sort_collections()

Closes https://github.com/StackGuardian/tirith/issues/185

@gabrilito1 gabrilito1 changed the title Change Simplify Type Checking in sort_collections Function Simplify type checking in sort_collections() Closes https://github.com/StackGuardian/tirith/issues/185 Sep 29, 2024
@gabrilito1
Copy link
Contributor Author

Done, give me a feedback asap

Copy link
Member

@refeed refeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll just do squash and rebase on this commit. Thanks!

@refeed refeed requested a review from samriddhi99 September 29, 2024 00:27
@refeed
Copy link
Member

refeed commented Sep 29, 2024

BTW @gabrilito1 , I forgot to mention that what I meant by the commit message is the git commit message. Ideally, we could squash the commits into one and then use git commit --amend to change the commit message and then do force push again. But for now, it's fine, we'll do it on my side, but if you want to change the commit message, feel free to do so

Copy link

Copy link
Contributor

@samriddhi99 samriddhi99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samriddhi99 samriddhi99 merged commit 88c74ce into StackGuardian:main Sep 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants