rename to tirith #76
rename to tirith #76
Conversation
| @@ -114,4 +114,4 @@ def pretty_print_result_dict(final_result_dict: Dict) -> None: | |||
| elif final_result_dict["final_result"] is None: | |||
| print(TermStyle.skipped("= Skipped final evaluator")) | |||
| else: | |||
| print(TermStyle.fail("✘ Not passed final evaluator")) | |||
| print(TermStyle.fail("✘ Failed final evaluation")) | |||
There was a problem hiding this comment.
I think the passed and skipped messages should also be changed to use the term "evaluation" instead of "evaluator"
| "Changelog": "https://github.com/stackguardian/policy-framework/blob/main/CHANGELOG.md", | ||
| "Issue Tracker": "https://github.com/stackguardian/policy-framework/issues", | ||
| "Changelog": "https://github.com/stackguardian/tirith/blob/main/CHANGELOG.md", | ||
| "Issue Tracker": "https://github.com/stackguardian/tirith/issues", | ||
| }, | ||
| keywords=["iac", "policy", "terraform", "policy as code"], | ||
| python_requires=">=3.8.*", |
There was a problem hiding this comment.
I think we also need to renew the install_requires to match Pipfile content, e.g. if people were to install this using pip install tirith (assumming we will use the name tirith in pypi) it will only install the deps listed in install_requires in this setup.py, not from the pipfile. Good way to test this is to create a new venv and do pip install . to see what it installs
A good tool to automate this is pypa/pipenv#1263 (comment)
Otherwise just writing it down manually is OK as well because our Pipfile currently only has 2 deps
There was a problem hiding this comment.
This can also be done in a separate PR though
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
No description provided.