Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Dec 23, 2025

This PR contains the following updates:

Package Change Age Confidence
aiosqlite >=0.22.0>=0.22.1 age confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

omnilib/aiosqlite (aiosqlite)

v0.22.1

Compare Source

Bug fix release

NOTE: Starting with v0.22.0, the aiosqlite.Connection object no longer
inherits from threading.Thread. If not using aiosqlite as a context manager,
clients must await connection.close() or call connection.stop() to ensure
the helper thread is completed and terminated correctly. A ResourceWarning
will be emitted for any connection that is garbage collected without being
closed or stopped.

  • Added synchronous stop() method to aiosqlite.Connection to enable safe
    cleanup and termination of the background thread without dependence
    on having an active event loop (#​370)
$ git shortlog -s v0.22.0...v0.22.1
     2	Amethyst Reese

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@claude
Copy link

claude bot commented Dec 23, 2025

PR Review: aiosqlite 0.22.0 → 0.22.1

Summary

Approve - This is a safe dependency upgrade with a minor bug fix.

Analysis

Changes:

  • Bumps aiosqlite from >=0.22.0 to >=0.22.1
  • Adds synchronous stop() method for safe cleanup without an active event loop

Code Compatibility:
✅ All database connections use proper context managers (async with)

  • DatabaseConfig._get_connection() uses async with self.engine.connect()
  • DatabaseConfig.begin_transaction() uses async with self.engine.connect()
  • Test fixtures properly call await db_config.close() for cleanup
  • No direct aiosqlite.connect() calls found

Impact:

  • No breaking changes
  • Improves resource cleanup for edge cases
  • The codebase already follows best practices with context managers and await close() in cleanup paths

Recommendation: Safe to merge

@aponcedeleonch aponcedeleonch merged commit 337319f into main Jan 2, 2026
7 checks passed
@aponcedeleonch aponcedeleonch deleted the renovate/aiosqlite-0.x branch January 2, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants