-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial setup #2
Conversation
# Conflicts: # app/src/main/java/edu/stanford/spezikt/MainActivity.kt # core/designsystem/build.gradle.kts # gradle/libs.versions.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Basler182 & @eldcn, thank you for the great PR and first foundation. I had a few very high-level comments and I am excited about the next steps.
Great job with the foundation @Basler182 and thank you for your input and improvements @eldcn!
It would be great if we can adjust the PR description to reflect the changes here in this PR 👍
pull_request: | ||
branches: [ "main" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might make sense to enable this for all PRs and add a workflow dispatch in case you want to manually tigger it.
pull_request: | |
branches: [ "main" ] | |
pull_request: | |
workflow_dispatch: |
In the long run, we might want to move this into a reusable GitHub action in the .github repo as we did for some of the other actions.
@@ -0,0 +1,102 @@ | |||
name: Android CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if we can include the setup to include a codecov reporting, REUSE specification, and markdown link checker here as well.
Sort of like we do for our Swift counterpart: https://github.com/StanfordSpezi/Spezi/blob/main/.github/workflows/pull_request.yml
I have added a CODECOV_TOKEN in the GitHub Actions secrets for this repo to be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if we want to provide something like the contact repository in our main API surface and to see if we can synchronize this a bit more with the IOS SDK. Not required to be changed in this PR but maybe something to look into.
…ezi/SpeziKt into feature/initial-setup
Inital Setup
♻️ Current situation & Problem
Link any open issues or pull requests (PRs) related to this PR. Please ensure that all non-trivial PRs are first tracked and discussed in an existing GitHub issue or discussion.
⚙️ Release Notes
📚 Documentation
Module Convention Plugin
Module Design
Module contact
✅ Testing
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: