feat(share): ✨ do not show share button if page is not a content page

StarCitizenTools · Jan 1, 2025 · 8c29416 · 8c29416
1 parent 75af101
commit 8c29416
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/includes/Components/CitizenComponentPageTools.php b/includes/Components/CitizenComponentPageTools.php
@@ -154,6 +154,7 @@ public function getTemplateData(): array {
 			 */
 			'is-uls-ready' => false,
 			'int-language-count' => $this->numLanguages,
+			'is-sharable' => $this->title->exists() && $this->title->isContentPage(),
 			'msg-citizen-share' => $this->localizer->msg( "citizen-share" )->text()
 		];
 	}

diff --git a/resources/skins.citizen.scripts/share.js b/resources/skins.citizen.scripts/share.js
@@ -4,13 +4,9 @@
  * @return {void}
  */
 function init() {
-	if ( !mw.config.get( 'wgIsArticle' ) ) {
-		return;
-	}
-
 	const shareButton = document.getElementById( 'citizen-share' );
 	if ( !shareButton ) {
-		mw.log.error( '[Citizen] Unable to find share button (#shareButton not found)' );
+		// Citizen will not add the citizen-share element if the share button is undesirable
 		return;
 	}
 

diff --git a/templates/PageTools.mustache b/templates/PageTools.mustache
@@ -4,7 +4,7 @@
 	object data-page-actions
 }}
 <div class="page-actions">
-	{{>Share}}
+	{{#is-sharable}}{{>Share}}{{/is-sharable}}
 	{{#has-languages}}{{>PageTools__languages}}{{/has-languages}}
 	{{#is-visible}}
 		{{#data-portlets.data-views}}{{>Menu}}{{/data-portlets.data-views}}