Skip to content

Commit

Permalink
fix(core): 🐛 remove outline styles for focus-visible as it is not wor…
Browse files Browse the repository at this point in the history
…king as intended

Also unset min-height in HTML because it caused TinyMCE to go crazy
  • Loading branch information
alistair3149 committed Dec 19, 2024
1 parent a01001e commit f2cc4fd
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 13 deletions.
13 changes: 5 additions & 8 deletions resources/skins.citizen.styles/common/common.less
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,18 @@ html {

html,
body {
min-height: ~'calc( 100vh - env( safe-area-inset-bottom,0 ) - env( safe-area-inset-top,0 ) )';
min-height: 100dvh;
padding: 0;
margin: 0;
color: var( --color-base );
accent-color: var( --color-progressive );
background: var( --color-surface-0 );
}

body {
min-height: ~'calc( 100vh - env( safe-area-inset-bottom,0 ) - env( safe-area-inset-top,0 ) )';
min-height: 100dvh;
}

// Apply border-box universally unless overwritten
*,
*::before,
Expand All @@ -30,12 +33,6 @@ body {
outline-color: var( --color-progressive );
}

// For some reason just overriding the outline-color is not enough
:focus-visible {
outline: var( --border-width-thick ) solid var( --color-progressive );
outline-offset: 1px;
}

::placeholder {
color: var( --color-subtle );
}
Expand Down
5 changes: 0 additions & 5 deletions skinStyles/extensions/TinyMCE/ext.tinymce.less
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,3 @@
*
* Date: 2024-12-19
*/

// Prevent TinyMCE from expanding itself limitlessly (#978)
body.mce-content-body {
min-height: auto;
}

0 comments on commit f2cc4fd

Please sign in to comment.