feature/seller-soroban-registration#171
Merged
KevinLatino merged 2 commits intoStarShopCr:mainfrom Sep 29, 2025
Merged
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughAdds seller on-chain registration feature: new Seller module (controller, service, DTOs), routes for building and submitting registration XDRs, and status retrieval. Updates User entity and introduces a migration to add payout wallet and registration flag. Includes unit and e2e tests. Changes primary key strategy for users to numeric IDs. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Seller as Seller (authenticated)
participant API as SellerController
participant Svc as SellerService
participant DB as Users Repo
Seller->>API: POST /seller/contract/build-register {payoutWallet}
API->>Svc: buildRegister(userId, dto)
Svc->>DB: findOne(userId)
DB-->>Svc: User
Svc->>DB: findOne({payoutWallet})
DB-->>Svc: (exists?|null)
Svc-->>API: { unsignedXdr, contractAddress }
API-->>Seller: { success, data }
rect rgba(230, 245, 255, 0.5)
note over Svc: Mock Soroban XDR build (placeholder)
end
sequenceDiagram
autonumber
actor Seller as Seller (authenticated)
participant API as SellerController
participant Svc as SellerService
participant DB as Users Repo
Seller->>API: POST /seller/contract/submit {signedXdr}
API->>Svc: submitRegister(userId, dto)
Svc->>DB: findOne(userId)
DB-->>Svc: User
Svc->>Svc: validate signedXdr (mock)
alt valid
Svc->>DB: update(userId, { payoutWallet, sellerOnchainRegistered: true })
DB-->>Svc: OK
Svc-->>API: { transactionHash, contractId, payoutWallet, registered: true }
API-->>Seller: { success, data }
else invalid
Svc-->>API: BadRequestException
API-->>Seller: 400 error
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 StarShop Pull Request
#156
Mark with an
xall the checkboxes that apply (like[x])📌 Type of Change
📝 Changes description
⏰ Time spent breakdown
Summary by CodeRabbit
New Features
Tests