Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TESTING: Hit Class #331

Merged
merged 9 commits into from
Jun 17, 2024
Merged

TESTING: Hit Class #331

merged 9 commits into from
Jun 17, 2024

Conversation

trentonyo
Copy link
Contributor

@trentonyo trentonyo commented Jun 17, 2024

🔨 PATCH TESTING: Hit Class, etc.

Old State

Hit class had some lines that weren't covered in the testing suite. Actually, it has a lot (because the GitHub issues integration lives there)

New State

Tested two additional lines. Also testing the pipeline is back up and running.

Updated todoon-issues workflow to accept exactly one duplicate closed issue, since we know that there is one. This is also a good example of advanced usage of the environment reporting for testing pipelines!

Definition of Done (pertinent to patch)

  • Contains no breaking changes
  • Changes are implemented in all components
  • Each component associated with issue is updated (no stubs)
  • All tests pass, no regressions
  • All documentation is updated, including release notes

…e new version of todoon in the pipeline which was just re-enabled
Updated duplicate issues and closed issue tests
…cate comment (the known example)

Removed closed localization comments
@trentonyo
Copy link
Contributor Author

Pushing to prod, need to get some workflows on the right side of the pipeline

@trentonyo trentonyo merged commit bb89234 into dev/staging Jun 17, 2024
3 of 4 checks passed
@trentonyo trentonyo deleted the dev/testing/todo-hit-tests branch June 17, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant