-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TESTING: Hit Class #331
Merged
Merged
TESTING: Hit Class #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e new version of todoon in the pipeline which was just re-enabled
Updated duplicate issues and closed issue tests
…cate comment (the known example) Removed closed localization comments
A line was accidentally removed
Pushing to prod, need to get some workflows on the right side of the pipeline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔨 PATCH TESTING: Hit Class, etc.
Old State
Hit class had some lines that weren't covered in the testing suite. Actually, it has a lot (because the GitHub issues integration lives there)
New State
Tested two additional lines. Also testing the pipeline is back up and running.
Updated todoon-issues workflow to accept exactly one duplicate closed issue, since we know that there is one. This is also a good example of advanced usage of the environment reporting for testing pipelines!
Definition of Done (pertinent to patch)