Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHORE: Code Quality, long-standing issues #351

Merged
merged 7 commits into from
Jun 19, 2024
Merged

CHORE: Code Quality, long-standing issues #351

merged 7 commits into from
Jun 19, 2024

Conversation

trentonyo
Copy link
Contributor

@trentonyo trentonyo commented Jun 19, 2024 •
edited
Loading

🔨 PATCH: Code Quality, long-standing issues

Updates

todo_check.py was getting a little bloated, started refactoring a lot of the run data and functionality out into another class.

Added test case for a todoon run with multiple languages

Added a test case for todo-ignore utility and resolved unhandled exception when targeting a file for contents but it's a directory instead

Fixed prod todoon workflow

Definition of Done (pertinent to patch)

  • Contains no breaking changes
  • Changes are implemented in all components
  • Each component associated with issue is updated (no stubs)
  • All tests pass, no regressions
  • All documentation is updated, including release notes

@trentonyo
Update utility functions and code refactoring
9201ab6 
This commit prioritizes the improvement of several utility functions, along with certain changes for code optimization. The hashing function is renamed to 'sha1_hash' for better clarity, and a new 'loc' function is introduced to facilitate localization. Other changes include argument updates in 'find_hits' function, removal of verbosity related parameters, and version updates in '__init__.py' and 'pyproject.toml'. Several test files have also been updated to match the modifications in utility functions.
@trentonyo
Started refactoring todo run data into class
ecb54be
@trentonyo
Pulled more into todo_app
b4c4bf2
@trentonyo
Write integration test for multiple languages in one run, closes #346
a12d6c3 
Updates to codebase will close #312 for now, could probably be better
@trentonyo
Added test and resolved unhandled exception for todo-ignore utility, c…
6f8395c 
…loses #242
@trentonyo
Removed deadcode and resolved todos
0e98496
@trentonyo trentonyo merged commit cdfb2b7 into dev/staging Jun 19, 2024
3 checks passed
@trentonyo trentonyo deleted the dev/chore/code-quality branch June 19, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@trentonyo