Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflows): integrate dockle #116

Merged
merged 10 commits into from
Aug 22, 2023
Merged

feat(workflows): integrate dockle #116

merged 10 commits into from
Aug 22, 2023

Conversation

Jose-Matsuda
Copy link
Contributor

@Jose-Matsuda Jose-Matsuda commented Aug 10, 2023

Will need to determine if we want dockle failing to block pushes.

Note that I made it such that it will fail the workflow on prs if the FATAL is seen, however if we are ok with that then I just have it ignore / exit-code 0 for the actual publish. This itself may require some elaboration / final decisions on it.

@Jose-Matsuda Jose-Matsuda requested a review from a team as a code owner August 10, 2023 15:22
@Jose-Matsuda
Copy link
Contributor Author

Jose-Matsuda commented Aug 11, 2023

I don't understand why it's failing, I've moved things around and as I refer to it again I don't see why I'm getting the whole

FATAL	unable to initialize a image struct: failed to initialize source: pinging container registry localhost:5000: 
Get "https://localhost:5000/v2/": dial tcp 127.0.0.1:5000: connect: connection refused

When it works fine for trivy, it must be something with dockle itself

Copy link
Contributor

@chuckbelisle chuckbelisle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first implementation of Dockle

@chuckbelisle chuckbelisle merged commit 92d6a63 into master Aug 22, 2023
4 checks passed
@chuckbelisle chuckbelisle deleted the 115-leverage-dockle branch August 22, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants