Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure ids are the expected type #2425

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Make sure ids are the expected type #2425

merged 2 commits into from
Aug 19, 2024

Conversation

mau11
Copy link
Member

@mau11 mau11 commented Aug 18, 2024 •
edited
Loading

Fixes #2421

Description

Bug reported unable to reassign campaign to another user. See issue ticket for more details.

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@mau11 mau11 marked this pull request as ready for review August 18, 2024 14:29
@mau11 mau11 changed the base branch from stage-main-14.1 to stage-main-14.0.2 August 18, 2024 14:34
@mau11 mau11 force-pushed the mz/message-review-issue-#2421 branch from b5203f8 to 1b49824 Compare August 19, 2024 05:43
engelhartrueben
engelhartrueben approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@engelhartrueben engelhartrueben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@engelhartrueben engelhartrueben merged commit f7f9038 into stage-main-14.0.2 Aug 19, 2024
17 checks passed
@mau11 mau11 mentioned this pull request Aug 19, 2024
Merged
7 tasks
@engelhartrueben engelhartrueben deleted the mz/message-review-issue-#2421 branch August 19, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelhartrueben engelhartrueben engelhartrueben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mau11 @engelhartrueben