Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove attempted reassignment of read-only object, nextProps #2459

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

mau11
Copy link
Member

@mau11 mau11 commented Sep 20, 2024

Fixes # (issue)

Description

We noticed that each time a text response was received while on the texter view page (.../app/[org-id]/todos), the page would crash (white screen + error in the console). This was caused by an attempt to clear the user.notifications property of nextProps. nextProps however is read only and cannot be updated in this way. Removal of this line allows the notification pop up to display, however it does not disappear until the user clicks on respond or any other action that navigates away from the page.

Screenshot 2024-09-20 at 12 20 32 PM

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@mau11 mau11 mentioned this pull request Sep 20, 2024
Copy link
Collaborator

@engelhartrueben engelhartrueben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@engelhartrueben engelhartrueben merged commit c236951 into stage-main-14.1 Sep 20, 2024
17 checks passed
@engelhartrueben engelhartrueben deleted the mz/fix-white-screen-error branch September 20, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 14.1
Development

Successfully merging this pull request may close these issues.

2 participants