Allow users to enter 0 hours for instant reassignment #2474

mau11 · 2024-10-01T07:16:35Z

Fixes # (issue)

Issue

dynamic assignments do not support a 0 hour response window
when 0 is entered in the input, the value disappears:
https://github.com/user-attachments/assets/f90a7a37-59f3-4659-847d-d980a866ea21

This branch fixes the UX and adds support for a 0 hour response window

I have manually tested my changes on desktop and mobile
The test suite passes locally with my changes
If my change is a UI change, I have attached a screenshot to the description section of this pull request
My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
I have made any necessary changes to the documentation
I have added tests that prove my fix is effective or that my feature works
My PR is labeled [WIP] if it is in progress

mau11 · 2024-10-01T07:20:02Z

src/components/CampaignDynamicAssignmentForm.jsx

-          control={
-            <Switch
-              color="primary"
-              checked={useDynamicReplies || false}


future - we need to add a linter to the repo to avoid these type of indentation updates

mau11 added 2 commits September 30, 2024 15:20

Allow users to enter 0 hours for instant reassignment

cc5b2d9

Update api to allow for 0 hours

b6e423b

mau11 changed the base branch from main to stage-main-14.1.1 October 1, 2024 07:17

mau11 commented Oct 1, 2024

View reviewed changes

engelhartrueben marked this pull request as ready for review October 1, 2024 15:35

mau11 requested a review from engelhartrueben October 1, 2024 16:22

mau11 marked this pull request as draft October 1, 2024 19:26